WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#53441 closed enhancement (fixed)

Remove unneeded gutenberg functions

Reported by: spacedmonkey's profile spacedmonkey Owned by: noisysocks's profile noisysocks
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

Remove unneeded gutenberg dev functions from core.

Attachments (1)

fatal.png​ (209.5 KB) - added by desrosj 4 years ago.

Download all attachments as: .zip

Change History (12)

#2 @spacedmonkey
4 years ago

  • Owner set to noisysocks
  • Status changed from new to assigned

#3 @noisysocks
4 years ago

Thanks. The changes to src/wp-includes/blocks/legacy-widget.php need to happen in Gutenberg as that file is copied over by grunt from @wordpress/widgets.

#4 @spacedmonkey
4 years ago

@noisysocks I have fixed it as part of ​https://github.com/WordPress/gutenberg/pull/32781. If you are interested.

#5 @noisysocks
4 years ago

Cool let's wait for GB32781 to be backported.

@desrosj
4 years ago

#6 @desrosj
4 years ago

Just noting this is causing a fatal error for me currently. gutenberg_get_widget_key() was never included in trunk. I think this is good to go. Going to ping in #core-editor to get final confirmation this can be merged.

This ticket was mentioned in ​Slack in #core-editor by desrosj. ​View the logs.
4 years ago

#9 @spacedmonkey
4 years ago

I have a workaround in the gutenberg package. See ​https://github.com/WordPress/gutenberg/pull/32902

This would require merge, package to be updated and then packaged update in WordPress core.

This ticket was mentioned in ​Slack in #core by spacedmonkey. ​View the logs.
4 years ago

#11 @noisysocks
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 51219:

Widgets: Remove unnecessary gutenberg_ functions

Removes temporary gutenberg_ functions which were required by the Legacy Widget
block until the Legacy Widget block was updated in [51149].

Follows [50996].
Fixes #53441.
Props spacedmonkey.

Note: See TracTickets for help on using tickets.