#53446 closed enhancement (fixed)
Twenty Twenty: Add privacy policy link to footer
Reported by: | ryelle | Owned by: | hellofromTonya |
---|---|---|---|
Milestone: | 5.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch needs-docs has-dev-note |
Focuses: | privacy | Cc: |
Description
If you have a privacy policy set, the page should be linked to from the footer of the site. The other bundled themes add this link using the_privacy_policy_link
, but Twenty Twenty does not.
In #43715, when the link was added to Twenty Seventeen and earlier, it was dropped next to "Powered by WordPress". I think the same could be done for Twenty Twenty.
Attachments (4)
Change History (20)
This ticket was mentioned in PR #1394 on WordPress/wordpress-develop by kapilpaul.
3 years ago
#2
- Keywords has-patch added; needs-patch removed
This PR will fix the missing Privacy link in the footer.
Trac Ticket: https://core.trac.wordpress.org/ticket/53446
#3
@
3 years ago
This Privacy Policy link is also missing in Twenty Twenty One theme. So added in that theme also. added the patch.
#4
@
3 years ago
- Focuses privacy added
@kapilpaul Thanks for the patch! I would rather avoid hiding the Privacy Policy link on smaller screens, so I tried another version.
Changes in 53446.1.diff:
- copying color settings from @kapilpaul's patch
- adding margin and
nowrap
for theto-the-top
link - adding a top margin for privacy link on smaller screens, switching to a left margin at 700px wide
- adding
flex-wrap
to avoid pushing individual elements onto two lines - unhiding powered-by link at 1000px instead of 700px so the
flex-wrap
is rarely needed
This ticket was mentioned in Slack in #core by sabernhardt. View the logs.
3 years ago
This ticket was mentioned in Slack in #core-test by hellofromtonya. View the logs.
3 years ago
#7
@
3 years ago
- Keywords commit added
The proposed patch works as expected. See screenshot above and this video recording for smaller screens behavior: https://i.gyazo.com/91c70a23ea2b673903a253c350f730d5.mp4
Marking for commit
.
#8
@
3 years ago
Sorry. I omitted to clarify that in my testing above, the Privacy Policy link uses the following title: "Politique de confidentialité".
This ticket was mentioned in Slack in #core-test by boniu91. View the logs.
3 years ago
#10
@
3 years ago
Test report
Environment
- WordPress: 5.9-alpha-51272-src
- PHP version: 7.4.23
- OS: 12.0 Beta
- Browser: Firefox Developer Edition 94.0b9
- Theme: Twenty Twenty
- Plugins: no
Test results
The patch 53446.1 applies correctly, and correctly adds the privacy policy page to the site footer (when is page is set and published).
#11
@
3 years ago
- Owner set to hellofromTonya
- Status changed from new to reviewing
Assigning to myself to prepare the commit.
#13
@
3 years ago
Thank you everyone for contributing! The patch has been committed and will ship with 5.9.
#14
@
3 years ago
- Keywords needs-docs needs-dev-note added
Maybe it would be nice to mention this change in a "Bundled Themes changes" dev note.
hellofromtonya commented on PR #1394:
3 years ago
#15
Thank you for your contribution! Fixed in https://core.trac.wordpress.org/changeset/52023.
#16
@
3 years ago
- Keywords has-dev-note added; commit needs-dev-note removed
Bundled themes update note:
https://make.wordpress.org/core/2022/01/05/bundled-theme-updates-with-wordpress-5-9/
Created patch.