Widget Block Editor: fatal error caused by unknown gutenberg_get_widget_key() function

[imath]

Hi,

I just noticed this fatal error when using the Widget Block editor:

Using the attached patch is fixing the issue, but I've noticed the source file is always reverted to the previous version when running grunt build so I guess the issue might be into this process.

[SergeyBiryukov]

Related: #53441

[spacedmonkey]

This issue will be fixed when #53427 is merged.

As for the removal of these gutenberg functions being removed, this should be handled in #53441

[spacedmonkey]

This issue will be fixed when #53427 is merged.

As for the removal of these gutenberg functions being removed, this should be handled in #53441

[desrosj]

Moving to the milestone to track, but probably should be a duplicate.

[hellofromTonya]

Before changeset 51216: can reproduce fatal error with legacy wdiget

[hellofromTonya]

Test after changeset 51216: fatal error resolved. Works as expected ✅

[hellofromTonya]

Testing

Env:

• OS: macOS Big Sur
• Browser: Firefox and Chrome
• Plugins: none

Testing with Beta 2

I can reproduce the problem ✅

Testing with Beta 3

Problem is resolved ✅

How?

Changeset [51216] from ticket #53427 added the new WP_Widget_Factory::get_widget_key method, which is the first conditional. With that new method, the else conditional is never reached in 5.8. The Gutenberg function gutenberg_get_widget_key will addressed separately but should no longer be a problem for causing fatal errors.

Marking the ticket as fixed.

@imath if you get time, could you also test and confirm it resolves the issue for you? If no, please reopen.

[desrosj]

In 51229:

Coding Standards: Apply an alignment fix from running composer format.

Follow up to [51216].
See #53481.

[imath]

@hellofromTonya thanks for your update. I've just tested and I confirm it fixed the issue for me.

[desrosj]

Duplicate of #53427.