WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#53484 closed defect (bug) (fixed)

unit test for current_datetime()

Reported by: pbearne Owned by: hellofromTonya
Priority: normal Milestone: 6.0
Component: Date/Time Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description


Change History (7)

This ticket was mentioned in ​PR #1414 on ​WordPress/wordpress-develop by ​pbearne.
5 years ago #1

Added test for current datetime

Trac ticket: https://core.trac.wordpress.org/ticket/53484#ticket

#2 @desrosj
5 years ago

  • Component Build/Test Tools → Date/Time
  • Milestone Awaiting Review → 5.9

#3 @hellofromTonya
5 years ago

  • Milestone 5.9 → 6.0
  • Owner set to hellofromTonya
  • Status new → accepted

With 5.9 Beta 1 tomorrow, moving this ticket to 6.0 and assigning it to me for review.

#4 @SergeyBiryukov
5 years ago

#54869 was marked as a duplicate.

​SergeyBiryukov commented on ​PR #1414:
5 years ago #5

Thanks for the PR! This looks good to me, but I think the test could be placed in a new file, tests/date/currentDatetime.php, for consistency with current_time() and other date/time tests. I can handle that on commit.

#6 @SergeyBiryukov
5 years ago

  • Resolution → fixed
  • Status accepted → closed

In 52611:

Date/Time: Add a unit test for the return type of current_datetime().

Follow-up to [45883].

Props pbearne.
Fixes #53484.

Note: See TracTickets for help on using tickets.