Context Navigation

← Previous Ticket
Next Ticket →

#53485 closed task (blessed) (fixed)

completing coverage for wp_date()

Reported by:	pbearne	Owned by:	hellofromTonya
Priority:	normal	Milestone:	6.1
Component:	Date/Time	Version:
Severity:	normal	Keywords:	has-unit-tests has-patch
Cc:		Focuses:

Description

a couple of the code paths are not tested

Change History (15)

This ticket was mentioned in PR #1415 on WordPress/wordpress-develop by pbearne.

5 years ago #1

added missing coverage paths to wp_date

Trac ticket: https://core.trac.wordpress.org/ticket/53485

#2 @desrosj
5 years ago

Milestone Awaiting Review → 5.9

#3 @hellofromTonya
5 years ago

Owner set to hellofromTonya
Status new → accepted

As 5.9 Beta 1 is tomorrow, moving this ticket to 6.0 and assigning to me for review.

#4 @hellofromTonya
5 years ago

Milestone 5.9 → 6.0

#5 @megphillips91
4 years ago

I'd like to help. I realized that I need a way to get wp_date but just the month, or just the date, or just the year. In my research, I do not think is currently supported, but could be fairly easy to implement as an enhancement. I think I can help with this and would like to if you would like a hand. Please let me know,

Meg

This ticket was mentioned in Slack in #core by mike. View the logs.

4 years ago

#7 @costdev
4 years ago

Type defect (bug) → task (blessed)

Per the discussion in the bug scrub, I'm changing this ticket to a Task.

This ticket was mentioned in PR #2643 on WordPress/wordpress-develop by costdev.

4 years ago #8

Trac ticket: https://core.trac.wordpress.org/ticket/53485

#9 @hellofromTonya
4 years ago

Milestone 6.0 → 6.1

With 6.0 RC1 tomorrow, moving this ticket to 6.1. It can committed when reviewed and ready.

peterwilsoncc commented on PR #2643:

4 years ago #10

@costdev To ask the silly question rather than assume: is this intended to replace #1415?

#11 @peterwilsoncc
4 years ago

Props due, please include in commit: @rarst

Review on original PR.

costdev commented on PR #2643:

4 years ago #12

@costdev To ask the silly question rather than assume: is this intended to replace #1415?

That's right, this PR updates #1415.

peterwilsoncc commented on PR #1415:

4 years ago #13

Superseded by PR #2643

#14 @peterwilsoncc
4 years ago

Resolution → fixed
Status accepted → closed

In 53810:

Date/Time: Increase test coverage of wp_date().

Props costdev, pbearne, rarst.
Fixes #53485.
See #55652.

peterwilsoncc commented on PR #2643:

4 years ago #15

Merged in https://core.trac.wordpress.org/changeset/53810 / d91b7744f1

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#53485 closed task (blessed) (fixed)

completing coverage for wp_date()

Description

Change History (15)

This ticket was mentioned in ​PR #1415 on ​WordPress/wordpress-develop by ​pbearne. 5 years ago #1

#2 @desrosj 5 years ago

#3 @hellofromTonya 5 years ago

#4 @hellofromTonya 5 years ago

#5 @megphillips91 4 years ago

This ticket was mentioned in ​Slack in #core by mike. ​View the logs. 4 years ago

#7 @costdev 4 years ago

This ticket was mentioned in ​PR #2643 on ​WordPress/wordpress-develop by ​costdev. 4 years ago #8

#9 @hellofromTonya 4 years ago

​peterwilsoncc commented on ​PR #2643: 4 years ago #10

#11 @peterwilsoncc 4 years ago

​costdev commented on ​PR #2643: 4 years ago #12

​peterwilsoncc commented on ​PR #1415: 4 years ago #13

#14 @peterwilsoncc 4 years ago

​peterwilsoncc commented on ​PR #2643: 4 years ago #15