WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#53485 closed task (blessed) (fixed)

completing coverage for wp_date()

Reported by: pbearne's profile pbearne Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.1 Priority: normal
Severity: normal Version:
Component: Date/Time Keywords: has-unit-tests has-patch
Focuses: Cc:

Description

a couple of the code paths are not tested

Change History (15)

This ticket was mentioned in ​PR #1415 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #1

added missing coverage paths to wp_date

Trac ticket: https://core.trac.wordpress.org/ticket/53485

#2 @desrosj
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#3 @hellofromTonya
3 years ago

  • Owner set to hellofromTonya
  • Status changed from new to accepted

As 5.9 Beta 1 is tomorrow, moving this ticket to 6.0 and assigning to me for review.

#4 @hellofromTonya
3 years ago

  • Milestone changed from 5.9 to 6.0

#5 @megphillips91
3 years ago

I'd like to help. I realized that I need a way to get wp_date but just the month, or just the date, or just the year. In my research, I do not think is currently supported, but could be fairly easy to implement as an enhancement. I think I can help with this and would like to if you would like a hand. Please let me know,

Meg

This ticket was mentioned in ​Slack in #core by mike. ​View the logs.
2 years ago

#7 @costdev
2 years ago

  • Type changed from defect (bug) to task (blessed)

Per the discussion in the bug scrub, I'm changing this ticket to a Task.

#9 @hellofromTonya
2 years ago

  • Milestone changed from 6.0 to 6.1

With 6.0 RC1 tomorrow, moving this ticket to 6.1. It can committed when reviewed and ready.

​peterwilsoncc commented on ​PR #2643:
2 years ago #10

@costdev To ask the silly question rather than assume: is this intended to replace #1415?

#11 @peterwilsoncc
2 years ago

Props due, please include in commit: @rarst

Review on ​original PR.

​costdev commented on ​PR #2643:
2 years ago #12

@costdev To ask the silly question rather than assume: is this intended to replace #1415?

That's right, this PR updates #1415.

​peterwilsoncc commented on ​PR #1415:
2 years ago #13

Superseded by PR #2643

#14 @peterwilsoncc
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 53810:

Date/Time: Increase test coverage of wp_date().

Props costdev, pbearne, rarst.
Fixes #53485.
See #55652.

Note: See TracTickets for help on using tickets.