WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#53490 closed task (blessed) (fixed)

adds missing test for xmlrpc function in functions.php

Reported by: pbearne Owned by: SergeyBiryukov
Priority: normal Milestone: 6.0
Component: Build/Test Tools Version:
Severity: normal Keywords: has-patch has-unit-tests
Cc: Focuses:

Description


Change History (10)

This ticket was mentioned in ​PR #1419 on ​WordPress/wordpress-develop by ​pbearne.
5 years ago #1

adds missing test for xmlrpc function in functions.php

Trac ticket: https://core.trac.wordpress.org/ticket/53490

#2 @desrosj
5 years ago

  • Milestone Awaiting Review → 5.9

​audrasjb commented on ​PR #1419:
5 years ago #3

Hi, thanks for the pull request. I committed some changes to this PR to address some Coding Standards issues.

#4 @audrasjb
5 years ago

GitHub checks are passing now :)

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
5 years ago

#6 @hellofromTonya
5 years ago

  • Milestone 5.9 → 6.0

Moving to 6.0 and adding to my test review queue.

#7 @costdev
5 years ago

  • Component XML-RPC → Build/Test Tools

Moving to the Build/Test Tools component.

I have made one suggestion on the PR and otherwise it looks good to me.

@hellofromTonya, do you have time for a review of the PR as a second set of eyes?

#8 @costdev
4 years ago

  • Type defect (bug) → task (blessed)

#9 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 53326:

Tests: Add unit tests for some XML-RPC functions:

  • xmlrpc_getposttitle()
  • xmlrpc_getpostcategory()
  • xmlrpc_removepostdata()

Props pbearne, audrasjb, costdev, SergeyBiryukov.
Fixes #53490.

​SergeyBiryukov commented on ​PR #1419:
4 years ago #10

Thanks for the PR! I have updated the test method descriptions to be a bit more detailed.

Merged in https://core.trac.wordpress.org/changeset/53326.

Note: See TracTickets for help on using tickets.