WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#53497 closed defect (bug) (fixed)

Avoid using "FSE" in function-names and inline docs

Reported by: aristath Owned by: desrosj
Milestone: 5.8 Priority: high
Severity: normal Version: 5.8
Component: Themes Keywords: has-patch has-unit-tests commit dev-reviewed fixed-major
Focuses: Cc:

Description

"FSE" was a term used in the initial development stages on Full Site Editing in the Gutenberg plugin. However, these terms bled into function-names and inline docs.
We should remove references to FSE since this is not what it will be called.
This should change prior to 5.8 because once functions get in, it will be extremely hard to remove them without adding deprecations & aliases.

Change History (20)

This ticket was mentioned in PR #1425 on WordPress/wordpress-develop by aristath.


4 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 5.8

#3 @SergeyBiryukov
4 months ago

  • Component changed from General to Themes
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @jorbin
4 months ago

I think the inline docs piece of this change is fine, but as @desrosj notes on the patch, guteberg_is_fse_theme is a function that will exist in released versions of Gutenberg, so I don't think that we can remove that reference.

#5 @desrosj
4 months ago

I'm going to commit the documentation changes and close this one out. We will need to add an additional function_exists() check if the function name is changed in Gutenberg-32950.

#6 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 51251:

Themes: Remove mention of “FSE” in Core.

Props aristath, jorbin.
Fixes #53497.

#8 @desrosj
4 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I found one more instance while reviewing the unit tests for #53497. The theme used to test block theme features is called fse. I think this can just be renamed to block-theme. Patch incoming.

#9 @desrosj
4 months ago

  • Version set to trunk

This ticket was mentioned in PR #1485 on WordPress/wordpress-develop by desrosj.


4 months ago

  • Keywords has-unit-tests added

This ticket was mentioned in PR #1485 on WordPress/wordpress-develop by desrosj.


4 months ago

  • Keywords has-unit-tests added

#12 @desrosj
4 months ago

  • Keywords commit dev-feedback added
  • Owner changed from SergeyBiryukov to desrosj
  • Status changed from reopened to assigned

#13 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 51370:

Themes: Remove mention of “FSE” in Core.

“FSE” themes are block themes.

Fixes #53497.

#15 @desrosj
4 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Marking [51370] for backport.

#16 @desrosj
4 months ago

In 51371:

Tests: Add missed file update in [51370].

See #53497.

#17 follow-up: @SergeyBiryukov
4 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Looks good to backport.

When something like this comes up next time, it would be great to rename the directory to preserve commit history, instead of removing and re-adding :)

#18 in reply to: ↑ 17 @desrosj
4 months ago

Replying to SergeyBiryukov:

When something like this comes up next time, it would be great to rename the directory to preserve commit history, instead of removing and re-adding :)

Sounds good! I thought I had fixed that before committing, but I guess I did not. I'll triple check that in the future. :)

#19 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51373:

Themes: Remove mention of “FSE” in Core.

“FSE” themes are block themes.

Props SergeyBiryukov.
Merges [51370-51371] to the 5.8 branch.
Fixes #53497.

#20 @desrosj
4 months ago

In 51374:

Themes: Remove mention of “FSE” in Core.

“FSE” themes are block themes.

Follow up to [51373].

Unprops desrosj.
Merges [51370-51371] to the 5.8 branch.
Fixes #53497.

Note: See TracTickets for help on using tickets.