#53497 closed defect (bug) (fixed)
Avoid using "FSE" in function-names and inline docs
Reported by: | aristath | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.8 | Priority: | high |
Severity: | normal | Version: | 5.8 |
Component: | Themes | Keywords: | has-patch has-unit-tests commit dev-reviewed fixed-major |
Focuses: | Cc: |
Description
"FSE" was a term used in the initial development stages on Full Site Editing in the Gutenberg plugin. However, these terms bled into function-names and inline docs.
We should remove references to FSE since this is not what it will be called.
This should change prior to 5.8 because once functions get in, it will be extremely hard to remove them without adding deprecations & aliases.
Change History (20)
This ticket was mentioned in PR #1425 on WordPress/wordpress-develop by aristath.
3 years ago
#1
- Keywords has-patch added
#3
@
3 years ago
- Component changed from General to Themes
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#4
@
3 years ago
I think the inline docs piece of this change is fine, but as @desrosj notes on the patch, guteberg_is_fse_theme
is a function that will exist in released versions of Gutenberg, so I don't think that we can remove that reference.
#5
@
3 years ago
I'm going to commit the documentation changes and close this one out. We will need to add an additional function_exists()
check if the function name is changed in Gutenberg-32950.
3 years ago
#7
Merged into Core in https://core.trac.wordpress.org/changeset/51251.
#8
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
I found one more instance while reviewing the unit tests for #53497. The theme used to test block theme features is called fse
. I think this can just be renamed to block-theme
. Patch incoming.
This ticket was mentioned in PR #1485 on WordPress/wordpress-develop by desrosj.
3 years ago
#10
- Keywords has-unit-tests added
Trac ticket: https://core.trac.wordpress.org/ticket/53497
This ticket was mentioned in PR #1485 on WordPress/wordpress-develop by desrosj.
3 years ago
#11
- Keywords has-unit-tests added
Trac ticket: https://core.trac.wordpress.org/ticket/53497
#12
@
3 years ago
- Keywords commit dev-feedback added
- Owner changed from SergeyBiryukov to desrosj
- Status changed from reopened to assigned
3 years ago
#14
Merged into Core in https://core.trac.wordpress.org/changeset/51370.
#15
@
3 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Marking [51370] for backport.
#17
follow-up:
↓ 18
@
3 years ago
- Keywords dev-reviewed added; dev-feedback removed
Looks good to backport.
When something like this comes up next time, it would be great to rename the directory to preserve commit history, instead of removing and re-adding :)
#18
in reply to:
↑ 17
@
3 years ago
Replying to SergeyBiryukov:
When something like this comes up next time, it would be great to rename the directory to preserve commit history, instead of removing and re-adding :)
Sounds good! I thought I had fixed that before committing, but I guess I did not. I'll triple check that in the future. :)
This is a companion to https://github.com/WordPress/gutenberg/pull/32950, renaming
fse
referencesTrac ticket: https://core.trac.wordpress.org/ticket/53497#ticket