Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53531 closed defect (bug) (fixed)

Twenty Twenty-One: Duotone on images not applied in dark mode

Reported by: walbo's profile walbo Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:


Twentytwenty one adds a filter to reduced the brightness and contrast on images to make them easier on the eyes. See

The issue is that this filter overwrites the filter used to add duotone.

Steps to recreate:

  1. Create a page and add a image with duotone.
  2. Visit the page frontend with dark mode enabled. Toggle to lightmode and the duodone shows.

Change History (5)

#1 @walbo
3 years ago

  • Component changed from Themes to Bundled Theme

This ticket was mentioned in PR #1440 on WordPress/wordpress-develop by walbo.

3 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
3 years ago

  • Summary changed from Twentytwentyone: Duotone on images not applied in dark mode to Twenty Twenty-One: Duotone on images not applied in dark mode

#4 @desrosj
3 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.8

Thanks @walbo! This one looks good to me in my testing.

#5 @desrosj
3 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 51253:

Twenty Twenty-One: Ensure Duotone images are displayed correctly in Dark Mode.

This reduces the specificity of the CSS selector applying a dimming effect to images so that the new Duotone feature is properly applied to images.

Props walbo.
Fixes #53531.

Note: See TracTickets for help on using tickets.