WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #53540, comment 9


Ignore:
Timestamp:
11/18/2021 10:39:51 PM (3 years ago)
Author:
costdev
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #53540, comment 9

    v1 v2  
    1616Any other occurrences of numeric `string` keys in core should be removed in a follow-up ticket.
    1717
    18 A regex search for `\[( )?'[0-9]'( )?\]` returns the following additional files:
     18A regex search for `\[( )?'[0-9]'( )?\]` returns the following additional occurrences:
    1919
     20Core:
    2021- `src/wp-admin/includes/media.php` (6)
    21 - `src/wp-includes/js/dist/components.js` (1)
    22 - `src/wp-includes/js/dist/components.js.map` (1)
    23 - `src/wp-includes/js/dist/editor.js` (1)
    24 - `src/wp-includes/js/dist/editor.js.map` (1)
    2522
    26 These can have the same change made.
     23These occurrences can have the same change made.
     24
     25Upstream:
     26- `getID3` - `src/wp-includes/ID3/module.audio.mp3.php` (3)
     27- `@wordpress/components` - `src/wp-includes/js/dist/components.js` (1)
     28- `@wordpress/components` - `src/wp-includes/js/dist/components.js.map` (1)
     29- `@wordpress/editor` - `src/wp-includes/js/dist/editor.js` (1)
     30- `@wordpress/editor` - `src/wp-includes/js/dist/editor.js.map` (1)
     31
     32These occurrences are an upstream matter.
    2733
    2834Searches for more than single digit numeric keys only shows `['01']`, `['02']`... which refer to months. This would probably have been better implemented as a numeric array with the leading zeroes added when needed, but any changes would require investigation for potential BC and performance issues.