Opened 3 years ago
Closed 3 years ago
#53546 closed defect (bug) (fixed)
Incorrect documentation for the 'upgrader_pre_install' filter
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.9 | Priority: | normal |
| Severity: | normal | Version: | 3.9 |
| Component: | Upgrade/Install | Keywords: | good-first-bug has-patch commit |
| Focuses: | docs | Cc: |
Description (last modified by )
The upgrader_pre_install filter description says:
Returning a truthy value, or one that could be evaluated as a WP_Error will effectively short-circuit the installation, returning that value instead.
As far as I can tell, only the second part is true. Returning a WP_Error object does indeed short-circuit the installation. Returning a truthy value, on the other hand, does nothing.
The description should be adjusted to remove the incorrect statement.
Introduced in [27673].
Attachments (1)
Change History (5)
Note: See
TracTickets for help on using
tickets.
Hi there, thanks for the patch! It looks great :)