WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#53549 closed defect (bug) (fixed)

Add generated artifacts folder to gitignore

Reported by: isabel_brison's profile isabel_brison Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

The e2e tests generate an /artifacts folder when there are test failures, storing snapshots of test state at the time the failure occurred. This folder should be added to .gitignore, as has been done in gutenberg already: ​https://github.com/WordPress/gutenberg/pull/26957

Change History (4)

This ticket was mentioned in ​PR #1445 on ​WordPress/wordpress-develop by ​tellthemachines.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53549

#2 @desrosj
4 years ago

  • Milestone changed from Awaiting Review to 5.8

Thanks @isabel_brison! I think this should probably happen for SVN as well. I'll make that adjustment when committing.

#3 @desrosj
4 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 51258:

Build/Test Tools: Add the artifacts directory to svn-ignore and .gitignore.

When E2E tests fail, test snapshots with more details about the failure are placed in this folder.

Props isabel_brison.
Fixes #53549.

​tellthemachines commented on ​PR #1445:
4 years ago #4

Closing as this has been fixed.

Note: See TracTickets for help on using tickets.