WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53554 closed enhancement (fixed)

Add timezone to update screen last checked time

Reported by: mkaz's profile mkaz Owned by: audrasjb's profile audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

The time displayed on at /wp-admin/update-core.php matches the server time which often may not be the timezone the person viewing the page is in. It would be a nice enhancement to include the timezone abbreviation with the time.

Attachments (1)

update-timezone.png​ (86.6 KB) - added by mkaz 3 years ago.

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in ​PR #1449 on ​WordPress/wordpress-develop by ​mkaz.
3 years ago #1

  • Keywords has-patch added

This adds the additional format T to the date format that will also display the timezone abbreviation. If timezone is set to UTC+0 it will show GMT+0000, if timezone set to a name, it will use the name abbreviation, for example PDT for America/Los_Angeles.

Trac ticket: https://core.trac.wordpress.org/ticket/53554

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See ​GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mkaz
3 years ago

#2 @audrasjb
3 years ago

Good catch.
Quick accessibility question: shouldn't we use e (Timezone identifier) to avoid abbreviation when possible?

#3 @audrasjb
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#4 @audrasjb
3 years ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

#5 @mkaz
3 years ago

@audrasjb I only noticed because my local was set to UTC+0 and said it was last checked in the future.

I'm not sure about e vs T, I personally prefer the shorter abbreviation.

Using e it will look like for (UTC-7 and UTC+0)

Last checked on June 29, 2021 at 4:00 pm America/Los_Angeles.
Last checked on June 29, 2021 at 4:00 pm +00:00.

And using T it will look like for (UTC-7 and UTC+0)

Last checked on June 29, 2021 at 4:00 pm PDT. 
Last checked on June 29, 2021 at 4:00 pm GMT+0000.

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
3 years ago

#7 @audrasjb
3 years ago

I think we're good to go. This can still be refined later if need.

#8 @audrasjb
3 years ago

  • Keywords commit added

Patch still applies cleanly against trunk. Marking for commit.

#9 @audrasjb
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52203:

Upgrade/Install: Add timezone info to last checked update time.

The time displayed on the Updates screen matches the server time which may not be the timezone the person viewing the page is in. This change includes the timezone information with the time.

Props mkaz.
Fixes #53554.

#10 @audrasjb
3 years ago

Thanks @mkaz for the ticket and patch. Committed to 5.9.

Note: See TracTickets for help on using tickets.