Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#53556 closed defect (bug) (fixed)

Add a new template-editing tag to the Theme API

Reported by: poena's profile poena Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.8.1 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit i18n-change fixed-major
Focuses: accessibility Cc:

Description

With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.

Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor

Attachments (3)

add-theme.png (138.8 KB) - added by desrosj 3 years ago.
53556.patch (520 bytes) - added by poena 3 years ago.
53556.diff (954 bytes) - added by desrosj 3 years ago.

Download all attachments as: .zip

Change History (16)

@desrosj
3 years ago

#1 @desrosj
3 years ago

  • Keywords reporter-feedback added

Just to clarify, this request is to add the Template Editing feature to this screen?

I don't think anything would prevent a theme author from adding that tag to their theme's header as I can't find any code that validates the list of tags for a theme.

I'm also not sure if a corresponding meta ticket would be needed to return that tag in the API results. I'd need to do some testing.

#2 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.8.1

The corresponding Meta ticket is #meta5802.

Core keeps its own list of these tags in get_theme_feature_list(), so we can add the new one there as well.

Related: #50164, #50165.

#3 @poena
3 years ago

Yes that is correct, I am suggesting that template editing is added to the feature list.

When a theme is submitted, it goes through an automated check to see if it is using the correct tags.
Until two weeks ago, this check did block themes that had incorrect tags.

#4 @SergeyBiryukov
3 years ago

  • Keywords needs-patch added; reporter-feedback removed

@poena
3 years ago

#5 @poena
3 years ago

  • Keywords has-patch added; needs-patch removed

@desrosj
3 years ago

#6 @desrosj
3 years ago

  • Keywords commit i18n-change added

53556.diff adds a @since tag to note when Template Editing was added as a feature.

I've marked as i8n-change as the Polyglot team would need to be made aware of this change should it be backported to 5.8.1. I think it makes sense to include it, but the #meta5802 ticket should ideally land at the same time.

Marking commit so that @SergeyBiryukov can shepherd both of these in within a reasonable amount of time of each other.

This ticket was mentioned in Slack in #themereview by poena. View the logs.


3 years ago

#8 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51510:

Themes: Add "Template Editing" to the list of WordPress theme features.

Follow-up to [meta11158].

Props poena, desrosj.
Fixes #53556. See #meta5802.

#9 @SergeyBiryukov
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 5.8 branch.

#10 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51516:

Themes: Add "Template Editing" to the list of WordPress theme features.

Follow-up to [meta11158].

Props poena, desrosj, SergeyBiryukov.
Merges [51510] to the 5.8 branch.
Fixes #53556. See #meta5802.

#11 in reply to: ↑ description @arnoldus3ma
2 years ago

  • Component changed from Themes to Plugins
  • Focuses accessibility added

Replying to poena:

With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.

Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor

#12 @arnoldus3ma
2 years ago

  • Keywords reporter-feedback added
  • Type changed from enhancement to defect (bug)
[[Image()]]
Last edited 2 years ago by arnoldus3ma (previous) (diff)

#13 @knutsp
2 years ago

  • Component changed from Plugins to Themes
  • Keywords reporter-feedback removed
Note: See TracTickets for help on using tickets.