#53556 closed defect (bug) (fixed)
Add a new template-editing tag to the Theme API
Reported by: | poena | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.8.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch commit i18n-change fixed-major |
Focuses: | accessibility | Cc: |
Description
With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.
Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor
Attachments (3)
Change History (16)
#2
@
3 years ago
- Milestone changed from Awaiting Review to 5.8.1
The corresponding Meta ticket is #meta5802.
Core keeps its own list of these tags in get_theme_feature_list()
, so we can add the new one there as well.
#3
@
3 years ago
Yes that is correct, I am suggesting that template editing is added to the feature list.
When a theme is submitted, it goes through an automated check to see if it is using the correct tags.
Until two weeks ago, this check did block themes that had incorrect tags.
#6
@
3 years ago
- Keywords commit i18n-change added
53556.diff adds a @since
tag to note when Template Editing was added as a feature.
I've marked as i8n-change
as the Polyglot team would need to be made aware of this change should it be backported to 5.8.1. I think it makes sense to include it, but the #meta5802 ticket should ideally land at the same time.
Marking commit
so that @SergeyBiryukov can shepherd both of these in within a reasonable amount of time of each other.
This ticket was mentioned in Slack in #themereview by poena. View the logs.
3 years ago
#8
@
3 years ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 51510:
#9
@
3 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting to the 5.8 branch.
#11
in reply to:
↑ description
@
3 years ago
- Component changed from Themes to Plugins
- Focuses accessibility added
Replying to poena:
With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.
Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor
Just to clarify, this request is to add the Template Editing feature to this screen?
I don't think anything would prevent a theme author from adding that tag to their theme's header as I can't find any code that validates the list of tags for a theme.
I'm also not sure if a corresponding meta ticket would be needed to return that tag in the API results. I'd need to do some testing.