Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#53556 closed defect (bug) (fixed)

Add a new template-editing tag to the Theme API

Reported by: poena Owned by: SergeyBiryukov
Priority: normal Milestone: 5.8.1
Component: Themes Version:
Severity: normal Keywords: has-patch commit i18n-change fixed-major
Cc: Focuses: accessibility

Description

With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.

Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor

Attachments (3)

add-theme.png​ (138.8 KB ) - added by desrosj 5 years ago.
53556.patch​ (520 bytes ) - added by poena 5 years ago.
53556.diff​ (954 bytes ) - added by desrosj 5 years ago.

Download all attachments as: .zip

Change History (16)

@desrosj
5 years ago

#1 @desrosj
5 years ago

  • Keywords reporter-feedback added

Just to clarify, this request is to add the Template Editing feature to this screen?

I don't think anything would prevent a theme author from adding that tag to their theme's header as I can't find any code that validates the list of tags for a theme.

I'm also not sure if a corresponding meta ticket would be needed to return that tag in the API results. I'd need to do some testing.

#2 @SergeyBiryukov
5 years ago

  • Milestone Awaiting Review → 5.8.1

The corresponding Meta ticket is ​#meta5802.

Core keeps its own list of these tags in get_theme_feature_list(), so we can add the new one there as well.

Related: #50164, #50165.

#3 @poena
5 years ago

Yes that is correct, I am suggesting that template editing is added to the feature list.

When a theme is submitted, ​it goes through an automated check to see if it is using the correct tags.
Until two weeks ago, this check did block themes that had incorrect tags.

#4 @SergeyBiryukov
5 years ago

  • Keywords needs-patch added; reporter-feedback removed

@poena
5 years ago

#5 @poena
5 years ago

  • Keywords has-patch added; needs-patch removed

@desrosj
5 years ago

#6 @desrosj
5 years ago

  • Keywords commit i18n-change added

53556.diff​ adds a @since tag to note when Template Editing was added as a feature.

I've marked as i8n-change as the Polyglot team would need to be made aware of this change should it be backported to 5.8.1. I think it makes sense to include it, but the ​#meta5802 ticket should ideally land at the same time.

Marking commit so that @SergeyBiryukov can shepherd both of these in within a reasonable amount of time of each other.

This ticket was mentioned in ​Slack in #themereview by poena. ​View the logs.


5 years ago

#8 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 51510:

Themes: Add "Template Editing" to the list of WordPress theme features.

Follow-up to ​[meta11158].

Props poena, desrosj.
Fixes #53556. See ​#meta5802.

#9 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for backporting to the 5.8 branch.

#10 @desrosj
5 years ago

  • Resolution → fixed
  • Status reopened → closed

In 51516:

Themes: Add "Template Editing" to the list of WordPress theme features.

Follow-up to ​[meta11158].

Props poena, desrosj, SergeyBiryukov.
Merges [51510] to the 5.8 branch.
Fixes #53556. See ​#meta5802.

#11 in reply to: ↑ description @arnoldus3ma
5 years ago

  • Component Themes → Plugins
  • Focuses accessibility added

Replying to poena:

With the template editing being a new feature in 5.8 that is opt-in,
a new tag should be added so that users can filter and search for themes that support it.

Suggest tag: template-editing
Label: Template editing
Description: Support template editing in the block editor

#12 @arnoldus3ma
5 years ago

  • Keywords reporter-feedback added
  • Type enhancement → defect (bug)
Version 0, edited 5 years ago by arnoldus3ma (next)

#13 @knutsp
5 years ago

  • Component Plugins → Themes
  • Keywords reporter-feedback removed
Note: See TracTickets for help on using tickets.