WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53577 closed defect (bug) (fixed)

Use `_x()` to translate Query block pattern category

Reported by: walbo Owned by: desrosj
Priority: normal Milestone: 5.8
Component: Editor Version:
Severity: normal Keywords: has-patch i18n-change commit fixed-major dev-reviewed
Cc: Focuses:

Description

Follow up on [50948] where the wrong translation function was used in the block pattern category.

The Query category will not be translated because Block pattern category is used as a domain and not context.

Change History (7)

This ticket was mentioned in ​PR #1460 on ​WordPress/wordpress-develop by ​walbo.
5 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/53577

#2 @desrosj
5 years ago

  • Keywords i18n-change added
  • Milestone Awaiting Review → 5.8

Thanks @walbo, good spot!

#3 @desrosj
5 years ago

  • Owner set to desrosj
  • Resolution → fixed
  • Status new → closed

In 51307:

Editor: Ensure the Query block pattern category is translatable.

Because the __() translation function was used here, the Query block pattern category string is not translatable. _x() is the correct function here as that passes the second parameter as context and not text domain.

Follow up to [50948].

Props walbo.
Fixes #53577.

#5 @desrosj
5 years ago

  • Component I18N → Editor
  • Keywords dev-feedback commit fixed-major added

Reopening for backport consideration.

#6 @ocean90
5 years ago

  • Keywords dev-reviewed added; dev-feedback removed
  • Resolution fixed
  • Status closed → reopened

#7 @desrosj
5 years ago

  • Resolution → fixed
  • Status reopened → closed

In 51308:

Editor: Ensure the Query block pattern category is translatable.

Because the __() translation function was used here, the Query block pattern category string is not translatable. _x() is the correct function here as that passes the second parameter as context and not text domain.

Follow up to [50948].

Props walbo.
Merges [51307] to the 5.8 branch.
Fixes #53577.

Note: See TracTickets for help on using tickets.