#53606 closed defect (bug) (fixed)
wp-api-generated.js needs updating, needs CI to test for changes
Reported by: | johnbillion | Owned by: | johnbillion |
---|---|---|---|
Milestone: | 5.8 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Build/Test Tools | Keywords: | has-unit-tests dev-reviewed commit |
Focuses: | Cc: |
Description
The tests/qunit/fixtures/wp-api-generated.js
file is under version control and it gets written to during the test_build_wp_api_client_fixtures()
test. Sometimes when the REST API schema gets updated this file gets forgotten.
This is currently the case and was introduced in [51241]. The file is not up to date with the latest REST API schema.
To reproduce:
composer test -- --filter test_build_wp_api_client_fixtures && git status --exit-code
We should:
- Update
wp-api-generated.js
to reflect the latest schema - Add tests to CI so it fails if this happens again
Change History (12)
#3
@
3 years ago
- Keywords dev-reviewed commit added; dev-feedback removed
PR looks good. Marking for commit and backport.
#4
@
3 years ago
- Component changed from REST API to Build/Test Tools
- Owner set to johnbillion
- Status changed from new to accepted
#7
@
3 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
[51351] looks good for backporting to the 5.8 branch.
3 years ago
#9
Merged into Core in https://core.trac.wordpress.org/changeset/51355.
Note: See
TracTickets for help on using
tickets.
In 51351: