WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53609 closed defect (bug) (fixed)

Responsive widget block embeds not showing in the customizer

Reported by: walbo Owned by: noisysocks
Priority: normal Milestone: 5.8.1
Component: Editor Version: 5.8
Severity: normal Keywords: has-patch fixed-major
Cc: Focuses:

Description

Embeds that are responsive are hidden in the customizer widgets. (ex. a YouTube embed)

Steps to reproduce:

  • Go to the widget section in the customizer.
  • Add a YouTube block and insert a video.
  • The block is inserted but the video is hidden in the sidebar.

Attachments (1)

Skjermbilde 2021-07-06 kl. 19.13.46.png​ (265.8 KB ) - added by walbo 5 years ago.

Download all attachments as: .zip

Change History (10)

@walbo
5 years ago

#1 @desrosj
5 years ago

  • Keywords needs-patch added
  • Milestone Awaiting Review → 5.8

Moving to 5.8 for testing.

#2 @walbo
5 years ago

  • Keywords has-patch added; needs-patch removed

Adding wp-embed-responsive to the body class seems to do the trick. Will do some testing.

#3 follow-up: @noisysocks
5 years ago

  • Keywords needs-patch added; has-patch removed

@walbo: Did you mean to upload a patch?

#4 @noisysocks
5 years ago

  • Milestone 5.8 → 5.8.1

#5 in reply to: ↑ 3 @walbo
5 years ago

  • Version → trunk

Replying to noisysocks:

@walbo: Did you mean to upload a patch?

Added a PR last night. ​https://github.com/WordPress/wordpress-develop/pull/1476 Not sure why it didn't add a comment/keyword in the ticket.

#6 @desrosj
5 years ago

  • Keywords has-patch added; needs-patch removed

#7 @noisysocks
5 years ago

  • Owner set to noisysocks
  • Resolution → fixed
  • Status new → closed

In 51716:

Customize: Add wp-embed-responsive class to body if using widgets block editor

Appends the wp-embed-responsive class to the body if the widgets block editor is
enabled. This fixes a bug preventing embeds (e.g. YouTube embeds) appearing in
the widgets block editor.

Fixes #53609.
Props walbo, kevin940726.

#8 @desrosj
5 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening to backport to 5.8 branch.

#9 @desrosj
5 years ago

  • Resolution → fixed
  • Status reopened → closed

In 51720:

Customize: Add wp-embed-responsive class to body if using widgets block editor

Appends the wp-embed-responsive class to the body if the widgets block editor is enabled. This fixes a bug preventing embeds (e.g. YouTube embeds) appearing in the widgets block editor.

Props walbo, kevin940726, noisysocks.
Merges [51716] to the 5.8 branch.
Fixes #53609.

Note: See TracTickets for help on using tickets.