WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#53626 new enhancement

Change Media upload failures string to not include "Security" messaging for each failure

Reported by: antpb Owned by:
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.7
Component: Media Keywords: good-first-bug has-patch
Focuses: Cc:

Description

Currently when uploading a media item that is not supported, the default message claims that the reason it cannot upload is due to security reasons. This is not always true. We should expand on this to be either conditional to show security message on valid security risks, or just a general "this file type is not supported" message for all types uploaded. I lean more toward the general message.

Attachments (1)

53626.diff (2.0 KB) - added by Presskopp 3 weeks ago.

Download all attachments as: .zip

Change History (4)

#1 @Presskopp
4 weeks ago

We already have a string "Sorry, this file type is not supported here." in

wp-includes/js/dist/media-utils.js:663

#2 @antpb
4 weeks ago

  • Milestone changed from Awaiting Review to 5.8.1

@Presskopp
3 weeks ago

#3 @Presskopp
3 weeks ago

  • Keywords has-patch added; needs-patch removed

I found 3 occurrences and changed them to the string which is already there

Note: See TracTickets for help on using tickets.