WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 9 days ago

Last modified 9 days ago

#53629 closed defect (bug) (fixed)

Twenty Twenty-one: List based widgets need style adjustments in the widget editor

Reported by: circlecube Owned by: audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.8
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: Cc:

Description

In Twenty Twenty-one, list based widgets need some styling adjustments in the widget editor to better match how they are displayed on the front end.

The archives, categories, meta, page list, and navigation menu are displaying list bullets in the editor but not on the front end.

Attachments (5)

Screen Shot 2021-07-08 editor.png (143.3 KB) - added by circlecube 5 months ago.
widgets in editor screenshot
Screen Shot 2021-07-08 frontend.png (134.6 KB) - added by circlecube 5 months ago.
widgets on front end screenshot
Screen Shot 2021-07-08 customizer.png (324.9 KB) - added by circlecube 5 months ago.
widgets in customizer screenshot
Capture d’écran 2021-11-23 à 23.20.11.png (208.6 KB) - added by audrasjb 9 days ago.
After patch: customizer
Capture d’écran 2021-11-23 à 23.19.53.png (191.5 KB) - added by audrasjb 9 days ago.
After patch: widget editor

Download all attachments as: .zip

Change History (21)

@circlecube
5 months ago

widgets in editor screenshot

@circlecube
5 months ago

widgets on front end screenshot

@circlecube
5 months ago

widgets in customizer screenshot

#1 @circlecube
5 months ago

I noticed that there are different differences between some of these widgets in the customizer and the front end too (and the widget editor).

Archives, Categories, and Page List widgets are displayed differently than in the widget editor and on the front end. They are without bullets here, but also without background color or matching link colors.

Meta and Menu widgets are displayed the same as they are in the editor, with bullets but they have proper colors to match the front end.

#2 @desrosj
5 months ago

  • Milestone changed from Awaiting Review to 5.9

This ticket was mentioned in PR #1761 on WordPress/wordpress-develop by Rahmon.


7 weeks ago

  • Keywords has-patch added; needs-patch removed

This PR moves the styles for ul and a from .widget-area to .widget.

Trac ticket: https://core.trac.wordpress.org/ticket/53629

#4 @Rahmohn
7 weeks ago

Hi @circlecube

I've created a PR to fix it. I would appreciate any feedback.

#5 @circlecube
3 weeks ago

  • Keywords needs-testing added

This looks like it should work and makes sense to me. Will need testing to make sure nothing else s awry with these changes.

I don't have time to test right now but have intentions to look soon as I can, so if anyone has time to look in the meantime feel free!

Last edited 3 weeks ago by circlecube (previous) (diff)

#6 @Boniu91
3 weeks ago

  • Keywords has-testing-info added

This ticket was mentioned in Slack in #core-test by boniu91. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #core-test by justinahinon. View the logs.


3 weeks ago

#9 @monikarao
2 weeks ago

Blank widget screen appear at my end on switching the PR - https://share.cspf.co/jkuERPx7

Could someone please confirm this issue ?

@audrasjb
9 days ago

After patch: customizer

@audrasjb
9 days ago

After patch: widget editor

#10 @audrasjb
9 days ago

  • Keywords needs-testing has-testing-info removed

#12 @audrasjb
9 days ago

  • Keywords commit added

Self-assigning for commit consideration.

#13 @audrasjb
9 days ago

  • Owner set to audrasjb
  • Status changed from new to assigned

#14 @audrasjb
9 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 52237:

Twenty Twenty-One: Style adjustments for list-based widgets in the widget editor.

This change brings style consistency between front-end and widget editor for list-based widgets.

Props circlecube, Rahmohn.
Fixes #53629.

Note: See TracTickets for help on using tickets.