Cron not updated correctly when deleting a future post

[develish]

Hi,

my name is Mariano and this is my first bug report so please bear with me :D

When I delete a future post using
wp_delete_post($post->ID)
it does not update the cron correctly.

I use this code to actually manually delete and unschedule the future posts

$posts = $wpdb->get_results( "SELECT ID FROM $wpdb->posts where post_status = 'future';" );
foreach ($posts as $post)
  {
    wp_clear_scheduled_hook( 'publish_future_post', $post->ID );
    wp_delete_post($post->ID)<
  }

Maybe a check if the post is of post_status future and then unscheduling it in the post deletion process would fix it.

I was not able to find the unschedule in post.php -> wp_delete_post

Thanks for consideration

Mariano

[tellyworth]

I've confirmed this in a unit test:

There was 1 failure:

1) test_delete_future_post_cron(WPTestIncludesPost)
Failed asserting that <integer:1195415622> is false.
/home/zem/projects/wordpress/wordpress-tests/wp-testcase/test_includes_post.php:146
/home/zem/projects/wordpress/wordpress-tests/wp-testlib/base.php:348
/home/zem/projects/wordpress/wordpress-tests/wp-test.php:92

See test_delete_future_post_cron() in ​http://svn.automattic.com/wordpress-tests/wp-testcase/test_includes_post.php.

[hailin]

After we delete a post, the post ID becomes invalid.
Therefore, even the entry was still in cron, when cron fires up, it tries to retrieve
an invalid post, it will return right away. logic is in wp_publish_post:

$post = get_post($post_id);

if ( empty($post) )

return;

So while a fix is good, I don't think there is real harm.

[Denis-de-Bernardy]

wontfix? or optimization?

[westi]

While this patch looks fine, it doesn't pass the unit test :-( the cron array still has the scheduled post in it afterwards.

[Denis-de-Bernardy]

I *think* I might know why... will find the ticket and report back

[Denis-de-Bernardy]

see: #8808 for the likely reason

[Denis-de-Bernardy]

so, if #8808 gets applied, and we use array( (string)$post_id ) instead, it should work.

[Denis-de-Bernardy]

on a separate note, it may be worth tweaking the cron a little bit so as to check for something like:

if args is numeric, and floatval() = intval() then cast to int.

that way, the stuff can be passed (string) $post_id etc, and it'll still work.

[westi]

Turns out this is due to hapazard sanitisation. [11282] makes it more regular.

[westi]

(In [11284]) Clear future publishing hook on post deletion. Fixes #5364 props develish and Denis-de-Bernardy.