WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 3 weeks ago

#53652 closed defect (bug) (fixed)

Copy suggested policy text to clipboard not triggered on click

Reported by: walbo Owned by: desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.7.1
Component: Privacy Keywords: has-patch commit fixed-major dev-reviewed
Focuses: Cc:

Description

In [50609] a <span> was added inside the copy button in the privacy guide page. The copy is triggered by checking if the target is `button.privacy-text-copy`, but after the change it picks up the span as the target. The pointer events on the span needs to be removed.

Steps to reproduce:

  1. Goto: wp-admin/options-privacy.php?tab=policyguide
  2. Open the WordPress accordion and click the button Copy suggested policy text to clipboard. (Make sure to click on the text/span)
  3. Nothing happends.
  4. Press Enter to trigger a click on the button and not the span. The Copied! text appears and the text is copied.

Change History (7)

This ticket was mentioned in PR #1495 on WordPress/wordpress-develop by walbo.


3 weeks ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 5.8.1

#3 @SergeyBiryukov
3 weeks ago

  • Milestone changed from 5.8.1 to 5.8

I think this is worth fixing in 5.8, as it's a recent regression and the fix seems simple enough.

#4 @desrosj
3 weeks ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 51431:

Privacy: Ensure the copy button actually copies the suggested privacy policy text.

Follow up to [50609].

Props walbo, SergeyBiryukov.
Fixes #53652. See #52891.

#5 @desrosj
3 weeks ago

  • Keywords commit fixed-major dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks @walbo, looks good. I've committed to trunk, and I agree including this in 5.8 is preferable. Reopening and marking for backport.

#6 @SergeyBiryukov
3 weeks ago

  • Keywords dev-reviewed added; dev-feedback removed

Tested [51431], works as expected here. Looks good to backport.

#7 @desrosj
3 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51433:

Privacy: Ensure the copy button actually copies the suggested privacy policy text.

Follow up to [50609].

Props walbo, SergeyBiryukov.
Merges [51431] to the 5.8 branch.
Fixes #53652. See #52891.

Note: See TracTickets for help on using tickets.