![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 5 years ago
Closed 5 years ago
#53652 closed defect (bug) (fixed)
Copy suggested policy text to clipboard not triggered on click
| Reported by: | walbo | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.8 |
| Component: | Privacy | Version: | 5.7.1 |
| Severity: | normal | Keywords: | has-patch commit fixed-major dev-reviewed |
| Cc: | Focuses: |
Description
In [50609] a <span> was added inside the copy button in the privacy guide page. The copy is triggered by checking if the target is `button.privacy-text-copy`, but after the change it picks up the span as the target. The pointer events on the span needs to be removed.
Steps to reproduce:
- Goto:
wp-admin/options-privacy.php?tab=policyguide - Open the
WordPressaccordion and click the buttonCopy suggested policy text to clipboard. (Make sure to click on the text/span) - Nothing happends.
- Press
Enterto trigger a click on the button and not the span. TheCopied!text appears and the text is copied.
Change History (7)
This ticket was mentioned in PR #1495 on WordPress/wordpress-develop by walbo.
5 years ago
#1
- Keywords has-patch added
#3
@
5 years ago
- Milestone 5.8.1 → 5.8
I think this is worth fixing in 5.8, as it's a recent regression and the fix seems simple enough.
#5
@
5 years ago
- Keywords commit fixed-major dev-feedback added
- Resolution fixed
- Status closed → reopened
Thanks @walbo, looks good. I've committed to trunk, and I agree including this in 5.8 is preferable. Reopening and marking for backport.
Note:
See TracTickets
for help on using tickets.
Trac ticket: https://core.trac.wordpress.org/ticket/53652