Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 19 months ago

#53654 closed defect (bug) (fixed)

Menus: Hide bulk-select options when no menus exist

Reported by: dlh's profile dlh Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.8
Component: Menus Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

The new "Bulk Select" checkbox and "Remove Selected Items" button are shown to the user even when no menus exist and the user is being invited to create their first menu.

Arguably, the new checkbox and button look somewhat awkward next to the "Give your menu a name..." instructions, and they conflict with the fact that the meta boxes for adding new items are disabled when no menus exist.

While the new checkbox and button are also visible when a menu exists but has no items, their being visible in that case is at least a little more consistent with the bulk-select checkbox on post list tables, which is also visible when the list table has no rows.

The linked PR would hide the bulk-select options when no menus exist, but a case could be made for disabling them instead to match the add-new meta boxes.

Attachments (1)

Screen Shot 2021-07-13 at 8.00.12 PM.png (316.3 KB) - added by dlh 3 years ago.

Download all attachments as: .zip

Change History (8)

#2 @sabernhardt
3 years ago

  • Milestone changed from Awaiting Review to 5.8.1

The patch looks good. Since RC4 was already packaged, I'll put this in the 5.8.1 milestone.

#3 @peterwilsoncc
3 years ago

  • Keywords commit added

LGTM, thanks David and Stephen.

#4 @peterwilsoncc
3 years ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 51539:

Menus: Hide bulk-select on new menu page.

Prevent the bulk-select option from displaying when adding a new menu. This also prevents the option from displaying when an administrator first visits the menu page and no menus are set.

Props dlh, sabernhardt.
Fixes #53654.

#5 @peterwilsoncc
3 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging to the 5.8 branch.

#6 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51596:

Menus: Hide bulk-select on new menu page.

Prevent the bulk-select option from displaying when adding a new menu. This also prevents the option from displaying when an administrator first visits the menu page and no menus are set.

Props dlh, sabernhardt, peterwilsoncc.
Merges [51539] to the 5.8 branch.
Fixes #53654.

#7 @audrasjb
19 months ago

In 54316:

Menus: Remove bulk action checkboxes when menu is empty.

This changeset removes the bulk action checkboxes when there is no menu item to select.

Follow-up to [51006], [51539].

Props oglekler, krishaweb, costdev, Boniu91, hugodevos, audrasjb.
Fixes #54799.
See #21603, #53654.

Note: See TracTickets for help on using tickets.