#53654 closed defect (bug) (fixed)
Menus: Hide bulk-select options when no menus exist
Reported by: | dlh | Owned by: | peterwilsoncc |
---|---|---|---|
Milestone: | 5.8.1 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Menus | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
The new "Bulk Select" checkbox and "Remove Selected Items" button are shown to the user even when no menus exist and the user is being invited to create their first menu.
Arguably, the new checkbox and button look somewhat awkward next to the "Give your menu a name..." instructions, and they conflict with the fact that the meta boxes for adding new items are disabled when no menus exist.
While the new checkbox and button are also visible when a menu exists but has no items, their being visible in that case is at least a little more consistent with the bulk-select checkbox on post list tables, which is also visible when the list table has no rows.
The linked PR would hide the bulk-select options when no menus exist, but a case could be made for disabling them instead to match the add-new meta boxes.
Attachments (1)
Change History (8)
This ticket was mentioned in PR #1497 on WordPress/wordpress-develop by dlh01.
3 years ago
#1
#2
@
3 years ago
- Milestone changed from Awaiting Review to 5.8.1
The patch looks good. Since RC4 was already packaged, I'll put this in the 5.8.1 milestone.
#4
@
3 years ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from new to closed
In 51539:
Trac ticket: https://core.trac.wordpress.org/ticket/53654