WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 2 days ago

#53658 reviewing defect (bug)

Display a user-facing message when the application passwords functionality is not available

Reported by: johnbillion Owned by: johnbillion
Milestone: 5.9 Priority: normal
Severity: normal Version: 5.6
Component: Application Passwords Keywords: good-first-bug has-patch commit
Focuses: administration Cc:

Description

The Application Passwords feature is not available on sites that don't use HTTPS (via is_ssl()). This applies to all environment types except "local" (via wp_get_environment_type()), which allows the feature to be used on non-HTTPS local environments.

When the feature isn't available there's no explanation shown to the user on the user profile editing screen, it simply doesn't appear. There should be an explanation provided with a link to related documentation about setting up HTTPS for production sites or setting the environment type for local environments.

Attachments (4)

patch_53658.diff (1.4 KB) - added by ashfame 3 months ago.
patch_53658.2.diff (1.4 KB) - added by ashfame 3 months ago.
Correct patch
53658.diff (1.5 KB) - added by johnbillion 7 weeks ago.
53658.2.diff (1.5 KB) - added by iluy 2 days ago.
Created a quick patch that makes the HelpHub link translatable, based off of @audrasjb latest comment. :)

Download all attachments as: .zip

Change History (12)

#1 @desrosj
3 months ago

  • Milestone changed from Awaiting Review to Future Release

@ashfame
3 months ago

#2 @ashfame
3 months ago

  • Keywords has-patch added; needs-patch removed

Docs doesn't have a page for migrating an install to HTTPS, though we have an issue going on for that now - https://github.com/WordPress/HelpHub/issues/333

Meanwhile, in my patch, I have added the link to search page and this can be updated with an actual page once that page is up and ready.

Last edited 3 months ago by ashfame (previous) (diff)

@ashfame
3 months ago

Correct patch

#3 @johnbillion
2 months ago

  • Milestone changed from Future Release to 5.9
  • Owner set to johnbillion
  • Status changed from new to reviewing

@johnbillion
7 weeks ago

#4 @johnbillion
7 weeks ago

53658.diff makes some adjustments to the wording and removes the link for HTTPS while we wait for an appropriate page to be produced.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


2 days ago

#6 @audrasjb
2 days ago

  • Keywords needs-refresh added

Hello, the patch still applies against trunk, but the HelpHub link needs to be translatable:

We should replace
'https://wordpress.org/support/article/editing-wp-config-php/#wp_environment_type'
with
__( 'https://wordpress.org/support/article/editing-wp-config-php/#wp_environment_type' )

@iluy
2 days ago

Created a quick patch that makes the HelpHub link translatable, based off of @audrasjb latest comment. :)

#7 follow-up: @audrasjb
2 days ago

  • Keywords commit added; needs-refresh removed

Thanks @iluy !
Marking this for commit

#8 in reply to: ↑ 7 @iluy
2 days ago

Happy to help. Hopefully in the near future, I'll be able to make more and more meaningful contributions ;)

Replying to audrasjb:

Thanks @iluy !
Marking this for commit

Note: See TracTickets for help on using tickets.