Add unit tests for v5.8 widget sidebar IDs

[JeffPaul]

r51239 was included in 5.8, but was intended to have included unit tests as part of the release. See parent ticket as possible starting point for a unit test patch on this.

[hellofromTonya]

Adding to my TODO list.

[strategio]

Here's the unit test proposed in the parent ticket (https://core.trac.wordpress.org/ticket/53452#comment:13):

​https://github.com/WordPress/wordpress-develop/pull/1448

[hellofromTonya]

Replying to strategio:

Here's the unit test proposed in the parent ticket (https://core.trac.wordpress.org/ticket/53452#comment:13):

​https://github.com/WordPress/wordpress-develop/pull/1448

Hey @strategio thanks for copying the link on this ticket. Status: I'll do a deep code review of your PR and, if needed, offer guidance. I suspect it'll be next week as my focus now is on 5.8.

[hellofromTonya]

Updating the keywords to identify that there is a PR ready for code review.

[desrosj]

To copy my thoughts over on the current patch:

The test looks good to me, though I'm not sure about where the test class actually belongs.

It looks like we have a file in DIR_TESTDATA with some widgets, but there are only 2 and they are all tied to a specific data provider. I've also been trying to think of a way to refactor out the need for the class at all, but nothing comes to mind right now.

I'm looking for some guidance/suggestions from contributors with more knowledge about why the suite is organized how it is.

[desrosj]

This has not received any attention the last few months. Going to bump to Future Release for now. @hellofromTonya is this still in your to-do list?

[hellofromTonya]

Replying to desrosj:

This has not received any attention the last few months. Going to bump to Future Release for now. @hellofromTonya is this still in your to-do list?

It is on my TODO list, though further down the list. I'll pull this one back into a milestone as soon as I get some free time to move it forward towards resolution.

[hellofromTonya]

As of today, I'm no longer a sponsored contributor and am starting a month or more AFK break. To not stand in the way, I'm clearing me as the ticket owner, which opens the ticket for someone to step in to shepherd this ticket forward to resolution.