#53679 closed defect (bug) (fixed)
The media library looks broken on mobile
Reported by: | andraganescu | Owned by: | joedolson |
---|---|---|---|
Milestone: | 5.8.1 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Media | Keywords: | has-patch needs-testing commit fixed-major |
Focuses: | css | Cc: |
Description
This follows up on https://github.com/WordPress/gutenberg/issues/32660
While testing the new Widgets editor I found that browsing the media library while using a small screen device is unuseable. Initially I thought that it's a problem of the Wdgets editor. However the bug exists in the post editor as well.
To reproduce
- Using latest Gutenberg trunk
- On a mobile device with a small screen (phone)
- Create a new post
- Add an image block
- Click the "media library" button
- The contents of the media library are unusable: images are small, on one column, cannot scroll
Expected behavior
I expect the modal media library to function on small screens similar to how the WP admin screen at Media > Library functions.
Attachments (3)
Change History (26)
This ticket was mentioned in PR #1502 on WordPress/wordpress-develop by adamziel.
3 years ago
#1
- Keywords has-patch added; needs-patch removed
#2
@
3 years ago
Here's a PR with a fix: https://github.com/WordPress/wordpress-develop/pull/1502
#3
follow-up:
↓ 9
@
3 years ago
- Component changed from General to Media
- Milestone changed from Awaiting Review to 5.8.1
#5
@
3 years ago
PR https://github.com/WordPress/wordpress-develop/pull/1502 working fine for me.
For CS instead of a duplicate selector can we use a parent selector?
Duplicate selector: .attachments-browser.attachments-browser .attachments-wrapper,
Parent selector: .media-frame-content .attachments-browser .attachments-wrapper,
#6
@
3 years ago
@mukesh27 Sure! I dislike these double selectors as well, good call here. I just updated https://github.com/WordPress/wordpress-develop/pull/1502 accordingly.
This ticket was mentioned in Slack in #core-editor by zieladam. View the logs.
3 years ago
#9
in reply to:
↑ 3
;
follow-up:
↓ 13
@
3 years ago
Replying to SergeyBiryukov:
Dimana saya dapat mengakses Component dan milestone
This ticket was mentioned in Slack in #core-media by desrosj. View the logs.
3 years ago
#14
@
3 years ago
- Keywords needs-refresh added; needs-testing removed
Testing on trunk with the patch applied, I am still seeing the bug on mid-sized screens, as shown in Markup 2021-08-03 at 14.22.19.png. There is still a little padding between the edge of the frame and the scroll bar.
This appears on both the post and widget editor's image block.
This ticket was mentioned in Slack in #core-media by antpb. View the logs.
3 years ago
This ticket was mentioned in Slack in #core-media by joedolson. View the logs.
3 years ago
#18
@
3 years ago
- Keywords needs-testing added; needs-refresh removed
@peterwilsoncc good spot! I updated the PR and I think we're good now – would you confirm?
#19
@
3 years ago
- Keywords commit added
Tested on both WP trunk and 5.8 with pull request applied.
Looks good on small, medium and large screens.
Thanks for updating.
While testing the new Widgets editor I found that browsing the media library while using a small screen device is unusable. Initially I thought that it's a problem of the Wdgets editor. However the bug exists in the post editor as well.
To reproduce:
Without this PR, the contents of the media library are unusable: images are small, on one column, cannot scroll.
With this PR, the contents of the media library is usable unusable: images are appropriately sized, view is scrollable.
Trac ticket: https://core.trac.wordpress.org/ticket/53679