Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53686 closed defect (bug) (fixed)

Update the `caniuse` data for 5.8

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 5.8 Priority: normal
Severity: normal Version: 5.8
Component: Build/Test Tools Keywords: has-patch commit fixed-major dev-reviewed
Focuses: Cc:

Description

The data used for generating CSS from Sass files is a bit outdated.

This should be updated, and the CSS should be regenerated to reflect the current browsers supported by the 5.8 release.

After running npx browserslist@latest --update-db, these are the changes to target browsers reported:

Target browser changes:
- and_chr 90
+ and_chr 91
- android 90
+ android 91
- chrome 89
+ chrome 91
- edge 89
+ edge 91
- firefox 88
- firefox 87
+ firefox 90
+ firefox 89
- ios_saf 14.5
+ ios_saf 14.5-14.7
- opera 75
- opera 74
+ opera 77
+ opera 76
- samsung 13.0
+ samsung 14.0

The changes resulting when running npm run grunt precommit:css after updating the data are very minor, so I think they're safe to include in the release as part of the dry-run checks performed:

  • A single -webkit prefix is removed for min-width, which was required for Safari <= 10.1 (0.06% total global usage). We support last 2 (13, 14).
  • 2 instances where the -o- prefix is added for tab-size. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.

Change History (8)

#2 @desrosj
3 years ago

  • Keywords commit added

#3 @desrosj
3 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 51456:

Build/Test Tools: Update the caniuse browser data and regenerate CSS.

This includes three minor updates to generated CSS files:

  • A single -webkit- prefix is removed for min-width, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions.
  • 2 instances where the -o- prefix are added for tab-size. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.

Props peterwilsoncc, jorbin.
Fixes #53686.

#4 @desrosj
3 years ago

  • Keywords dev-feedback fixed-major added

#5 @desrosj
3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version set to trunk

Reopening to backport [51456].

#6 @peterwilsoncc
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

[51456] looks good for merging to the 5.8 branch. Review process:

  • Applied diff to 5.8 branch, all nice and clean
  • Run npm i (needs to be done manually as package.json hasn't changed)
  • Run npm run grunt postcss to verify changes to css files are correct

Everything ran as expected.

#7 @peterwilsoncc
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51458:

Build/Test Tools: Update the caniuse browser data and regenerate CSS.

This includes three minor updates to generated CSS files:

  • A single -webkit- prefix is removed for min-width, which was required for Safari <= 10.1 (0.06% total global usage). WordPress only supports the last two versions.
  • 2 instances where the -o- prefix are added for tab-size. This appears to be for Opera Mobile, which has creeped back over the 1% global usage.

Props peterwilsoncc, jorbin, desrosj.
Merges [51456] to the 5.8 branch.
Fixes #53686.

Note: See TracTickets for help on using tickets.