WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53696 closed defect (bug) (fixed)

wp_add_iframed_editor_assets_html() not checking for block editor

Reported by: swissspidy Owned by: peterwilsoncc
Priority: normal Milestone: 5.8.1
Component: Editor Version: 5.8
Severity: normal Keywords: has-patch commit fixed-major
Cc: Focuses:

Description

wp_add_iframed_editor_assets_html in WP 5.8 adds some inline JavaScript in the admin footer on post.php/post-new.php even if the current screen does not use the block editor.

This JS should not be added if using a different editor.

The function should use WP_Screen::is_block_editor() accordingly.

Attachments (1)

53696.diff​ (467 bytes ) - added by desrosj 5 years ago.

Download all attachments as: .zip

Change History (6)

@desrosj
5 years ago

#1 @desrosj
5 years ago

  • Keywords has-patch added; needs-patch removed

#2 @peterwilsoncc
5 years ago

  • Keywords commit added

53696.diff​ looks good to me, testing notes:

  • Confirmed presence of scripts on post edit page
  • Enabled classic editor, confirmed scripts still present
  • Applied patch
  • Confirmed scripts no longer present on classic editor
  • Disabled classic editor, confirmed scripts present on block editor

All dandy 🌻

#3 @peterwilsoncc
5 years ago

  • Owner set to peterwilsoncc
  • Resolution → fixed
  • Status new → closed

In 51540:

Editor: Prevent block-editor JavaScript loading in other editors.

Add a check to wp_add_iframed_editor_assets_html() confirming the edit post screen is using the block-editor before including block-editor specific JavaScript. For the classic and other editors the function returns early without any output.

Props swissspidy, desrosj.
Fixes #53696.

#4 @peterwilsoncc
5 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for merging to the 5.8 branch.

#5 @desrosj
5 years ago

  • Resolution → fixed
  • Status reopened → closed

In 51593:

Editor: Prevent block-editor JavaScript loading in other editors.

Add a check to wp_add_iframed_editor_assets_html() confirming the edit post screen is using the block-editor before including block-editor specific JavaScript. For the classic and other editors the function returns early without any output.

Props swissspidy, desrosj, peterwilsoncc.
Merges [51540] to the 5.8 branch.
Fixes #53696.

Note: See TracTickets for help on using tickets.