Possible Regression - Border settings not displaying for Button Block

[daisyo]

The control to adjust the radius of buttons is not displaying for the button block. There were some design changes to the border settings controls since 5.7 but, as far as I'm aware, the option to set a border radius for a button block should be present in 5.8.

Tested on 5.8-RC4-51460 with Twenty Twenty One and Twenty Fifteen Themes, No active plugins.

Steps to reproduce:

• Create Post
• Add Buttons Block to content
• Switch to single Button block
• Observe that border settings are not present in the block settings panel

[daisyo]

Border settings not present in 58

[daisyo]

Border settings present in 5.7

[priethor]

I can reproduce the ticket as described with versions 5.7.2 (has border settings) and 5.8-RC4-51460 (doesn't have border settings).

[desrosj]

I am also able to reproduce. Moving this to 5.8.1 for now, but this will likely require a report to be opened upstream.

[Mamaduka]

It looks like the "border" feature isn't enabled. I can see the BorderPanel component in React DevTools, but it returns early because of this.

The attached screenshots showcase the difference between Gutenberg and 5.8 features.

WordPress 5.8

Gutenberg 11.1

I tried updating wp-includes/theme.json but this had no effect. So I assume there's another place where allowed features are listed.

Trac ticket: https://core.trac.wordpress.org/ticket/53697

Adds missing border setting and enables it for Button block.

I've only included border-radius settings. I wasn't sure about the others.

@nosolosw @jorgefilipecosta

Any chance this can make its way into the 5.8.1 milestone, given that it’s a regression and takes away an option that was previously there?

[mikeschroder]

@bgardner: I agree we should fix it in 5.8.1 if possible.

Just a quick note that it is in the milestone:
https://core.trac.wordpress.org/ticket/53697#comment:2

Merged into Core in https://core.trac.wordpress.org/changeset/51538.

[jorgefilipecosta]

Fixed in https://core.trac.wordpress.org/changeset/51538.

[desrosj]

Reopening for backporting.

[peterwilsoncc]

In 51547:

Block Editor: Add missing border setting on button block.

This commit fixes a regression on WordPress 5.8 that made the border radius setting on the buttons block disappear.

Props Mamaduka, daisyo, priethor, desrosj, mikeschroder.
Merges [51538] to the 5.8 branch.
Fixes #53697.

[desrosj]

#53881 was marked as a duplicate.

[desrosj]

#53896 was marked as a duplicate.