#53697 closed defect (bug) (fixed)
Possible Regression - Border settings not displaying for Button Block
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.8.1 | Priority: | normal |
Severity: | normal | Version: | 5.8 |
Component: | Editor | Keywords: | has-patch fixed-major |
Focuses: | Cc: |
Description
The control to adjust the radius of buttons is not displaying for the button block. There were some design changes to the border settings controls since 5.7 but, as far as I'm aware, the option to set a border radius for a button block should be present in 5.8.
Tested on 5.8-RC4-51460 with Twenty Twenty One and Twenty Fifteen Themes, No active plugins.
Steps to reproduce:
- Create Post
- Add Buttons Block to content
- Switch to single Button block
- Observe that border settings are not present in the block settings panel
Attachments (4)
Change History (20)
#1
@
4 years ago
I can reproduce the ticket as described with versions 5.7.2 (has border settings) and 5.8-RC4-51460 (doesn't have border settings).
#2
@
4 years ago
- Component changed from General to Editor
- Keywords needs-patch added
- Milestone changed from Awaiting Review to 5.8.1
- Version set to trunk
I am also able to reproduce. Moving this to 5.8.1 for now, but this will likely require a report to be opened upstream.
This ticket was mentioned in Slack in #core-editor by desrosj. View the logs.
4 years ago
#4
@
4 years ago
It looks like the "border" feature isn't enabled. I can see the BorderPanel
component in React DevTools, but it returns early because of this.
The attached screenshots showcase the difference between Gutenberg and 5.8 features.
I tried updating wp-includes/theme.json
but this had no effect. So I assume there's another place where allowed features are listed.
This ticket was mentioned in PR #1513 on WordPress/wordpress-develop by Mamaduka.
4 years ago
#5
- Keywords has-patch added; needs-patch removed
Trac ticket: https://core.trac.wordpress.org/ticket/53697
Adds missing border setting and enables it for Button block.
I've only included border-radius settings. I wasn't sure about the others.
youknowriad commented on PR #1513:
4 years ago
#6
@nosolosw @jorgefilipecosta
4 years ago
#7
Any chance this can make its way into the 5.8.1 milestone, given that it’s a regression and takes away an option that was previously there?
#8
@
4 years ago
@bgardner: I agree we should fix it in 5.8.1 if possible.
Just a quick note that it is in the milestone:
https://core.trac.wordpress.org/ticket/53697#comment:2
4 years ago
#9
Merged into Core in https://core.trac.wordpress.org/changeset/51538.
#11
@
4 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for backporting.
#12
@
4 years ago
- Owner set to peterwilsoncc
- Resolution set to fixed
- Status changed from reopened to closed
In 51547:
Border settings not present in 58