WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 2 months ago

#53710 accepted defect (bug)

WP Update notice shown twice

Reported by: Presskopp Owned by: audrasjb
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch has-screenshots
Focuses: Cc:

Description

On updates (wp-admin/update-core.php) the message to update manually to a new localised version is shown twice.

Expected behaviour would be to show the message only once and then also show a message about the possibility to update to the US version manually.

Original phrase:
"You can update from WordPress %1$s to <a href="%2$s">WordPress %3$s</a> manually:"

Attachments (2)

570571.png (10.8 KB) - added by Presskopp 2 months ago.
572580.png (26.1 KB) - added by Presskopp 2 months ago.

Download all attachments as: .zip

Change History (3)

@Presskopp
2 months ago

@Presskopp
2 months ago

#1 @audrasjb
2 months ago

  • Component changed from Administration to Upgrade/Install
  • Milestone changed from Awaiting Review to 5.9
  • Owner set to audrasjb
  • Status changed from new to accepted

Good point.

I suspect this is because the list_core_update() function is called two times, inside a foreach loop.

https://build.trac.wordpress.org/browser/trunk/wp-admin/update-core.php?marks=140#L222

Note: See TracTickets for help on using tickets.