WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53716 closed defect (bug) (fixed)

The "/" missing at the end of image tag

Reported by: radixweb's profile radixweb Owned by: audrasjb's profile audrasjb
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.8
Component: Help/About Keywords: has-patch commit fixed-major
Focuses: coding-standards Cc:

Description

The "/" missing at the end of the image tag, Which is need as a standard workflow. So I have added the "/" at the end of image tag.

Attachments (2)

53716.patch​ (642 bytes) - added by radixweb 5 years ago.
Added the "/" at the end of image tag
53716.1.diff​ (790 bytes) - added by audrasjb 5 years ago.
Help/About: Add missing slashes in About page img and source HTML tags

Download all attachments as: .zip

Change History (10)

@radixweb
5 years ago

Added the "/" at the end of image tag

#1 @radixweb
5 years ago

  • Keywords has-patch added

#2 in reply to: ↑ description @ankitmaru
5 years ago

Replying to radixweb:

The "/" missing at the end of the image tag, Which is need as a standard workflow. So I have added the "/" at the end of image tag.

Looks good.
Thanks for the patch.

#3 @TobiasBg
5 years ago

The <source> tag right above it could then probably also get an /.

#4 @sabernhardt
5 years ago

  • Component changed from Customize to Help/About
  • Focuses accessibility removed
  • Milestone changed from Awaiting Review to 5.8.1

@audrasjb
5 years ago

Help/About: Add missing slashes in About page img and source HTML tags

#5 @audrasjb
5 years ago

  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for spotting this.
53716.1.diff looks good to me.

#6 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51473:

Help/About: Add / character to <img> and <source> tags.

While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51418].

Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb.
Fixes #53716.

#7 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.8.1 consideration.

#8 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51506:

Help/About: Add / character to <img> and <source> tags.

While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51418].

Props radixweb, ankitmaru, TobiasBg, sabernhardt, audrasjb, SergeyBiryukov.
Merges [51473] to the 5.8 branch.
Fixes #53716.

Note: See TracTickets for help on using tickets.