Classic Editor: 'new-post-slug' input missing a label

[sabernhardt]

The input for changing the permalink of a post does not have a label in the Classic Editor.

[sabernhardt]

The patch includes a spellcheck attribute, which was suggested on #50499.

Also, I think the translation needs something else. I chose the existing string "URL Slug" instead of new text, and I still have English there with a French profile.

[audrasjb]

The change looks good to me, thanks @sabernhardt!

I can confirm the URL Slug string already exists and is translated in fr_FR (​https://translate.wordpress.org/projects/wp/dev/fr/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=7578448&filters%5Btranslation_id%5D=62892203) so I'm not sure why it's not translated. Maybe because the existing occurence comes from the block editor?

[sabernhardt]

Note that the proposed label is not visual, so it would need testing with a screen reader.

Testing the extra part to make sure the browser does not run spellcheck on the input (when enabled) might be easier visibly, so you can verify the jagged underline no longer shows under an intentionally misspelled word.

[audrasjb]

Self-assigning for proper testing using a screen-reader.

[audrasjb]

Tested on VoiceOver

[audrasjb]

I tested on a visual browser to make sure it doesn't trigger spellcheck on the input field, and it looks good to me. Also, the label is correctly rendered at least on VoiceOver.

Trac ticket: https://core.trac.wordpress.org/ticket/53725

[audrasjb]

Just added a GitHub PR to run checks, and it appears slug_label needs to be defined. Fixing this right now :)

[audrasjb]

Tests are passing now. Ready for commit.

[audrasjb]

In 52225:

Editor: Add missing label to new-post-slug input on Classic Editor.

Previously, the input for changing the permalink of a post does not have a label in the Classic Editor. This change adds a visually hidden label. It also makes sure browsers do not run spellcheck on the input field.

Props sabernhardt.
Fixes #53725.

Committed via https://core.trac.wordpress.org/changeset/52225.