WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 6 of Ticket #53729


Ignore:
Timestamp:
07/21/2021 11:25:06 PM (5 years ago)
Author:
hellofromTonya
Comment:

w00t!

Replying to ravipatel:

@hellofromTonya yes i will do patch for this.

Updated the ticket's title and description to match the new scope of this ticket (helps in discoverability).

Also moving into the 5.9 milestone.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #53729

    • Property Component Administration → Help/About
    • Property Keywords needs-patch added; has-patch removed
    • Property Type defect (bug) → enhancement
    • Property Milestone Awaiting Review → 5.9
    • Property Owner set to hellofromTonya
    • Property Status new → accepted
    • Property Summary $title never used, Replaced with text → Add readability comment to $title variable used in admin-header

  • Ticket #53729 – Description

    initial v6  
    1 [[Image(https://prnt.sc/1e3ulze)]]
     1Add a readability comment above each instance of `$title = __( '' )` in each admin panel's file. This `$title` is used to populate the `<title>` element which is built in the reusable `wp-admin/admin-header.php` file.
    22
    3 We have fixed in patch please review. Code re-usability.
     3The comment will avoid confusion on panel file's where the translated content reads the same for the `<title>` and `<h1>`. For example, the confusion can occur in the `wp-admin/privacy.php`:
     4
     5{{{#!php
     6$title = __( 'Privacy' );
     7...
     8require_once ABSPATH . 'wp-admin/admin-header.php';
     9...
     10<div class="about__header-title">
     11        <h1>
     12                <?php _e( 'Privacy' ); ?>
     13        </h1>
     14</div>
     15}}}