About the docs of safecss_filter_attr function

[tmatsuur]

Currently, the docs for the safe_style_css filter contains the following information.

 * @since 5.8.0 Added support for `calc()` and `var()` values.

Shouldn't the above information be in the docs for this function?

[SergeyBiryukov]

Hi there, thanks for the ticket!

Looking at the safecss_filter_attr()​ function, all the updates to allowed CSS attributes since WordPress 4.4 are indeed documented in the safe_style_css filter rather than in the function.

Would it make more sense to move this list to the function DocBlock instead?

[sabernhardt]

Support for specific properties was added to the safecss_filter_attr function, not the filter, so moving the list from one DocBlock to the other makes sense to me.

I could upload a patch, but I think this would be a good-first-bug.

[tmatsuur]

Thanks @SergeyBiryukov , @sabernhardt

As you pointed out, I also think it would be more appropriate to move the list to the function DocBlock.

[muhammadfaizanhaidar]

@SergeyBiryukov , @sabernhardt @tmatsuur
I have just added a patch shifted details to function doc block from filter doc block. Thanks for this opportunity to contribute.

Updated safecss_filter_attr function's doc block.
Shifted the updates for this function from 'safe_style_css' filter doc block to the safecss_filter_attr function's doc block.

Trac ticket: https://core.trac.wordpress.org/ticket/53731

File details
wp-includes/wp-includes/kses.php line 2152.
wp-includes/wp-includes/kses.php line 2183.
​https://github.com/MuhammadFaizanHaidar/wordpress-develop/blob/master/src/wp-includes/kses.php

[muhammadfaizanhaidar]

I have just added a patch shifted details to function doc block from filter doc block. Thanks for this opportunity to contribute.

[SergeyBiryukov]

In 51729:

Docs: Move @since notes from the safe_style_css filter to the safecss_filter_attr() function.

The filter allows to modify the list of allowed CSS attributes, however support for specific CSS attributes is added to the function rather than the filter.

Follow-up to [37931], [38121], [42880], [44136], [44531], [45242], [45363], [46235], [46793], [50634], [50923].

Props tmatsuur, muhammadfaizanhaidar, sabernhardt.
Fixes #53731.

Thanks for the PR! Merged in https://core.trac.wordpress.org/changeset/51729.

@SergeyBiryukov I am honored to contribute. Thanks for merging the PR!