Opened 5 years ago
Closed 5 years ago
#53769 closed defect (bug) (fixed)
Bundled themes: block-patterns.php file should use `get_template_directory_uri` instead of `get_stylesheet_directory_uri`
| Reported by: | audrasjb | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.8.1 |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | has-patch fixed-major |
| Cc: | Focuses: |
Description
Related: #53752
In Bundled Themes, the block-patterns.php file should use get_template_directory_uri instead of get_stylesheet_directory_uri to avoid issues with child themes.
Attachments (2)
Change History (10)
#4
@
5 years ago
- Keywords fixed-major added
- Resolution fixed
- Status closed → reopened
Reopening for backporting to the 5.8 branch.
#5
@
5 years ago
[51483] looks good to me for merging in to the 5.8 branch.
As fatal errors are quite bad, I think version bumps should be committed on this ticket and quick turnaround releases done with a single fix for the affected themes.
#6
@
5 years ago
- Twenty Ten becomes 3.5
- Twenty Eleven becomes 3.9
- Twenty Twelve becomes 3.5
Bumps in readme and style.css; change log added to readme (todo: codex update).
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Good catch!
Twenty Ten, Twenty Eleven, and Twenty Twelve appear to be the only affected themes. The rest are already using
get_template_directory_uri()for images ininc/block-patterns.php.