WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#5378 closed enhancement (wontfix)

Replace existing wp-includes/rss.php

Reported by: chmac Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: needs-patch dev-feedback
Focuses: Cc:

Description

The current rss.php file is somewhat out of date and doesn't include a number of functions. For example, it doesn't support multiple categories. I'll attach a modified version that is distributed with wp-autoblog which is significantly better. I haven't tested it extensively, but it does provide a number of useful features which the current file doesn't. Plus, it's a single-file, drop-in replacement.

Attachments (2)

rss.php (70.9 KB) - added by chmac 6 years ago.
Suggested replacement for wp-includes/rss.php
5378.r6603.diff (89.5 KB) - added by hansengel 6 years ago.
Patch version of rss.php, so changes are visible

Download all attachments as: .zip

Change History (9)

chmac6 years ago

Suggested replacement for wp-includes/rss.php

comment:1 johnbillion6 years ago

  • Type changed from defect to enhancement

chmac, to save people manually trawling through your attached file, can you give us a summary of the changes? For example, is there support for enclosures? And what are the new functions that are included?

comment:2 chmac6 years ago

The file includes a summary of changes I believe. I noticed that it handles categories much better, and also creates a date_timestamp field (saves a bunch of hassle calculating dates). Those were the only two features I specifically needed, so I haven't looked at what else it does in detail.

var_dump(fetch_rss($url)) provides an awful lot more with this file. Beyond "more" I didn't really pay attention to specifically what it does.

hansengel6 years ago

Patch version of rss.php, so changes are visible

comment:3 hansengel6 years ago

  • Keywords has-patch needs-testing added

comment:4 DD326 years ago

  • Keywords dev-feedback added

comment:5 DD325 years ago

  • Keywords needs-patch added; has-patch needs-testing removed

Patch is stale.

The RSS Cacher could do with a tune up, For example, The dashboard only requires 2 posts with their description, Not the 15posts cached in the database, The extra length can really bloat out the RSS options quickly, But that would require modifying the Magpie core class more. Garbage collection of old RSS items would also be well received by plugin authors who fetch dynamic RSS feeds i'm sure.

See also: #5378

comment:6 DD325 years ago

(Dont ask why i'd post a circular reference there..)

See also: #6897

comment:7 ryan5 years ago

  • Milestone 2.9 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

We now use SimplePie. see #9198

Note: See TracTickets for help on using tickets.