WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53782 closed enhancement (fixed)

Privacy Screen: Add a space below the privacy policy page selector for i18n

Reported by: audrasjb Owned by: ryelle
Priority: normal Milestone: 5.9
Component: Privacy Version:
Severity: normal Keywords: has-patch has-screenshots commit
Cc: Focuses: css

Description

On the Privacy settings screen, it would be nice to add a margin-bottom below the privacy policy page selector, because in some languages the submit bottom is on a new line and it doesn't looks super good without a margin (see screenshots below).

Attachments (5)

53782.diff​ (521 bytes ) - added by audrasjb 5 years ago.
Capture d’écran 2021-07-26 à 13.30.30.png​ (123.6 KB ) - added by audrasjb 5 years ago.
Before patch, on fr_FR localized website
Capture d’écran 2021-07-26 à 13.29.20.png​ (122.6 KB ) - added by audrasjb 5 years ago.
After patch, on a fr_FR localized website
Capture d’écran 2021-07-26 à 13.29.12.png​ (96.4 KB ) - added by audrasjb 5 years ago.
After patch on en_US: it doesn't change anything, we is the desired behaviour :-)
53782.1.diff​ (521 bytes ) - added by guillaumeturpin 5 years ago.
Fixed coding standard

Download all attachments as: .zip

Change History (10)

@audrasjb
5 years ago

@audrasjb
5 years ago

Before patch, on fr_FR localized website

@audrasjb
5 years ago

After patch, on a fr_FR localized website

@audrasjb
5 years ago

After patch on en_US: it doesn't change anything, we is the desired behaviour :-)

#1 @audrasjb
5 years ago

  • Keywords has-patch has-screenshots added; needs-patch removed

#2 @mukesh27
5 years ago

  • Keywords needs-refresh added

Patch 53782.diff​ looks fine to me.

For consistency can you please use 0.5em instead of .5em in CSS?

@guillaumeturpin
5 years ago

Fixed coding standard

#3 @guillaumeturpin
5 years ago

  • Keywords needs-refresh removed

Hi,
I'm new to WordPress core and this is my first patch.
I refreshed the previous patch.

#4 @audrasjb
5 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 5.9

Hi @guillaumeturpin and welcome to WordPress Core.
Thanks @mukesh27 for spotting this.

Marking this ticket for commit and milestoning it to 5.9 as it's good to ship.

#5 @ryelle
5 years ago

  • Owner set to ryelle
  • Resolution → fixed
  • Status new → closed

In 51645:

Privacy: Add space below page selector.

Sometimes the submit button wraps to a new line, either because the button label translation is long, or there are long page names. When it wraps, there should be space between the select dropdown and the button.

Props audrasjb, mukesh27, guillaumeturpin.
Fixes #53782.

Note: See TracTickets for help on using tickets.