WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53793 closed enhancement (fixed)

Return type does not match the actual return type in PHPDoc.

Reported by: ankitmaru's profile ankitmaru Owned by: johnbillion's profile johnbillion
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Filesystem API Keywords: has-patch
Focuses: docs, coding-standards Cc:

Description

Return type does not match the actual return type in PHPDoc.
File: class-wp-filesystem-base.php

Attachments (2)

class-wp-filesystem-base.php_53793.patch​ (530 bytes) - added by ankitmaru 3 years ago.
class-wp-filesystem-base.php_53793_2.patch​ (1015 bytes) - added by ankitmaru 3 years ago.

Download all attachments as: .zip

Change History (5)

@ankitmaru
3 years ago

#1 @johnbillion
3 years ago

  • Component changed from General to Filesystem API
  • Milestone changed from Awaiting Review to 5.9
  • Owner set to johnbillion
  • Status changed from new to reviewing
  • Version 5.8 deleted

Good spot and thanks for the patch @ankitmaru. It looks like the corresponding docs for the places where permsn is used (containing the return value of getnumchmodfromh()) also need to be updated from int to string. Can you take a look?

@ankitmaru
3 years ago

#2 @ankitmaru
3 years ago

@johnbillion I have added the new patch, Please check it and let me know if anything is missed.

#3 @SergeyBiryukov
3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 51494:

Docs: Correct @return type for WP_Filesystem_Base::getnumchmodfromh().

Follow-up to [9117].

Props ankitmaru, johnbillion.
Fixes #53793.

Note: See TracTickets for help on using tickets.