Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#53795 closed defect (bug) (fixed)

WP5.8 CSS Validation errors

Reported by: jim5471's profile jim5471 Owned by:
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)


I created a ticket in the Gutenberg repository on 3 June and the issue hasn't been actioned.

So many people work very hard on WordPress development and to release software that hasn't been fully validated is difficult to understand.

Some part of WordPress will fail to function correctly and more people will waste effort trying to discover why.

Am I wrong to report this ?

Change History (5)

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Editor
  • Description modified (diff)
  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Hi there, welcome back to WordPress Trac! Thanks for the report.

It looks like you have already reported this at in the Gutenberg repository, which is the correct place for this issue.

I'm closing the ticket as reported-upstream, as the fix needs to made upstream in the Gutenberg plugin first. When the changes are made, they will be backported to WordPress core as part of package updates.

#2 @SergeyBiryukov
3 years ago

  • Milestone set to 5.8.1
  • Resolution reported-upstream deleted
  • Status changed from closed to reopened

On second thought, reopening for more visibility, and to see if this can be prioritized for 5.8.1.

#3 @peterwilsoncc
3 years ago

There is a pull request in progress for this on the Gutenberg repository.

The reported error on line 267 (selector list in :not()) is a false positive as the validator is for CSS 3 and :not() began supporting selector lists in CSS Level 4. All browsers supported by WordPress support the feature.

The reported error on line 2283 is a genuine positive: width: none is not valid.

#4 @desrosj
3 years ago

  • Keywords has-patch added
  • Milestone changed from 5.8.1 to 5.8.2

With 5.8.1 RC in less than 24 hours, I'm going to punt this one to 5.8.2. I've commented on the PR, and if it can be refined before tomorrow it can be reconsidered for 5.8.1.

#5 @desrosj
3 years ago

  • Milestone changed from 5.8.2 to 5.9
  • Resolution set to fixed
  • Status changed from reopened to closed

Just pushed a fix for the formatting of the :not() selector to keep that the same.

This is not breaking anything, but rather a minor annoyance when validating the CSS, so I'm going to push this to 5.9.

I'll be merging the PR on GitHub once the tests complete, so I'm also going to close this out. The change will be merged into WordPress when packages are updated next.

Note: See TracTickets for help on using tickets.