Make WordPress Core

Opened 6 months ago

Closed 2 months ago

Last modified 3 weeks ago

#53797 closed defect (bug) (fixed)

Bundled Themes: Add "Tested up to" in style.css

Reported by: kafleg Owned by: desrosj
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Twenty Twenty theme is missing Tested up to in style.css and this is the required thing. I have added Tested up to: 5.8 in Github.

Attachments (2)

53797.patch (8.7 KB) - added by ravipatel 6 months ago.
I have added a all default dev themes style with Tested up to : 5.8
53797.2.patch (10.8 KB) - added by ravipatel 6 months ago.
with changes style-rtl.css

Download all attachments as: .zip

Change History (12)

This ticket was mentioned in PR #1521 on WordPress/wordpress-develop by kafleg.


6 months ago

  • Keywords has-patch added; needs-patch removed

Tested up to is required and it needs to be mentioned in style.css

Trac ticket: https://core.trac.wordpress.org/ticket/53797

This ticket was mentioned in PR #1521 on WordPress/wordpress-develop by kafleg.


6 months ago

Tested up to is required and it needs to be mentioned in style.css

Trac ticket: https://core.trac.wordpress.org/ticket/53797

#3 @mukesh27
6 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords commit added
  • Version 5.8 deleted

Hi there!

Thanks for the ticket and PR. It looks fine.

Marking for commit.

#4 @mukesh27
6 months ago

  • Milestone changed from Awaiting Review to 5.9

#5 @desrosj
6 months ago

  • Keywords commit removed

Related: #53276, #52982, #51501, #50503, #48517, #53580, meta-461.

Thanks for this, @kafleg!

I've taken a closer look, and it appears that Twenty Twenty-One is the only bundled theme that currently has Tested up to in style.css headers. This was an intentional decision at the time because WordPress Core did not yet utilize this header (see comment:5:ticket:48517).

Since then, [47145] added support for required WordPress versions in Core, but Tested up to is still not supported by Core within style.css headers.

I was not able to locate a ticket in Trac to consider adding this support to style.css files, so this could serve as that. But more work would be required, as Core itself must have a reason to add support for this header.

An example of this could be adding "This theme has not been marked as compatible with your version of WordPress." messages to match those shown when working with plugins.

Twenty Twenty theme is missing Tested up to in style.css and this is the required thing.

Can you expand on the "required thing"? Is this now enforced for themes residing on WordPress.org? If I recall correctly, that was not the case previously (it was a soft requirement/suggestion).

#6 @kafleg
6 months ago

@desrosj Yes, it was recommended before. But, while reviewing themes we used to ask theme authors to add them. But when the Theme Check plugin is updated to the newer version, Tested up to is now REQUIRED. You can also see the Requirements handbook about this.

#7 @SergeyBiryukov
6 months ago

  • Summary changed from Add Tested up to in style.css to Bundled Themes: Add "Tested up to" in style.css

@ravipatel
6 months ago

I have added a all default dev themes style with Tested up to : 5.8

@ravipatel
6 months ago

with changes style-rtl.css

#8 @mukesh27
6 months ago

@ravipatel Thanks for the patch.

#9 @desrosj
2 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 52221:

Bundled Themes: Update the “Tested up to” header to 5.9.

This updates the “Tested up to” header in the readme.txt file for all bundled theme.

This also adds the “Tested up to” header to the style.css file for older default themes (Twenty Twenty and earlier). Previously, this header was only recommended, so it was not included. It is now required, per the theme handbook: https://make.wordpress.org/themes/handbook/review/required/#9-files.

Props kafleg, mukesh27, ravipatel.
Fixes #53797.

#10 @prbot
3 weeks ago

hellofromtonya commented on PR #1521:

Thank you for contribution! This PR was included in a larger batch of fixes in https://core.trac.wordpress.org/changeset/52221. As the ticket is now closed, closing this PR too.

Note: See TracTickets for help on using tickets.