Do not provide initial_edits for properties that are not supported by the current post type.

[youknowriad]

I noticed that edit-form-blocks.php (block editor initialization) always provides "title", "content" and "excerpt" initial edits in the initializeEditor call even though these properties might not be supported by the current post type being edited.

This creates a subtle bug in the post editor where as soon as you open a "new post", the editor considers the content "dirty", meaning changes are applied and you can't "leave" the editor without having the "unsaved changes" notice.

I think we should consider updating the $initial_edits variable declaration to only add the properties that are supported by the current CPT.

Trac ticket: https://core.trac.wordpress.org/attachment/ticket/53813

[h71]

Empty line removed.

[h71]

My first patch! I had to wait for Github checks. The new diff is attached after passing all checks.

[audrasjb]

Self-assigning for review.

[audrasjb]

Reproducing the issue by removing "excerpt" support in a custom post type

[audrasjb]

I can confirm the proposed patch fixes the issue.

Marking for commit.

Trac ticket: https://core.trac.wordpress.org/ticket/53813

[audrasjb]

Tests are passing well.

[audrasjb]

In 52230:

Editor: Do not provide initial_edits for properties that are not supported by the current post type.

Previously, the block editor initialization always provided "title", "content" and "excerpt" initial edits in the initializeEditor call even though these properties might not be supported by the current post type being edited. This leads to a bug in the post editor where as soon as one would open a "new post", the editor considers the content "dirty", meaning changes are applied and it is not possible to leave the editor without encountering an "unsaved changes" notice.

This change updates the $initial_edits variable declaration to only provide the properties that are supported by the current post type.

Props youknowriad, h71.
Fixes #53813.

Fixed in 52230

Fixed in 52230

[talldanwp]

Just want to surface my comment on the PR here - ​https://github.com/WordPress/wordpress-develop/pull/1743#discussion_r754031590

Looks like this fix caused a bug.

I've created a PR to fix the problem - ​https://github.com/WordPress/wordpress-develop/pull/1929

Trac ticket: https://core.trac.wordpress.org/ticket/53813

This PR fixes an issue with the already submitted patch for that trac ticket.

See ​https://github.com/WordPress/wordpress-develop/pull/1743#discussion_r754031590 for details.

Thanks for the fix @talldan, I'll commit this in few mins

[SergeyBiryukov]

In 52231:

Editor: Check the correct post type support property for initial_edits.

The property to check should be editor instead of content, as posts don't have a content support property.

This addresses an e2e test failure in Gutenberg.

Follow-up to [52230].

Props talldanwp.
See #53813.

Committed by @SergeyBiryukov in the meantime 😉

Sorry, didn't know you were around too 😅

No worries, and thank you for jumping into this :)