Build doesn't support Docker Compose V2

[pbearne]

I can't get the build to work
downloaded fresh master from ​https://github.com/WordPress/wordpress-develop

npm install
npm run build:dev
npm run env:start

then get this error

PS C:\Users\XX\Documents\xwp\wordpress-develop> npm run env:install

> WordPress@5.9.0 env:install C:\Users\XX\Documents\xwp\wordpress-develop
> node ./tools/local-env/scripts/install.js

time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_UID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_GID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_UID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_GID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The WP_MULTISITE variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_UID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The PHP_FPM_GID variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The GITHUB_REF variable is not set. Defaulting to a blank string."
time="2021-07-28T16:33:01-04:00" level=warning msg="The GITHUB_EVENT_NAME variable is not set. Defaulting to a blank string."
services.cli.environment.LOCAL_PHP_MEMCACHED must be a string, number or null
node:child_process:675
    throw err;
    ^

Error: Command failed: docker-compose run --rm cli config create --dbname=wordpress_develop --dbuser=root --dbpass=password --dbhost=mysql --path=/var/www/src --force
    at checkExecSyncError (node:child_process:636:11)
    at execSync (node:child_process:672:15)
    at wp_cli (C:\Users\XX\Documents\xwp\wordpress-develop\tools\local-env\scripts\install.js:48:2)
    at Object.<anonymous> (C:\Users\XX\Documents\xwp\wordpress-develop\tools\local-env\scripts\install.js:10:1)
    at Module._compile (node:internal/modules/cjs/loader:1083:30)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1112:10)
    at Module.load (node:internal/modules/cjs/loader:948:32)
    at Function.Module._load (node:internal/modules/cjs/loader:789:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)
    at node:internal/main/run_main_module:17:47 {
  status: 15,
  signal: null,
  output: [ null, null, null ],
  pid: 30196,
  stdout: null,
  stderr: null
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! WordPress@5.9.0 env:install: `node ./tools/local-env/scripts/install.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the WordPress@5.9.0 env:install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

I am not sure why this is broken
Docker v20.10.7

[desrosj]

Hi @pbearne,

I had experienced this a week or so ago. When I looked at my Docker setup, I had "Use Docker Compose V2 checked off under Experimental Features. I unchecked this, and then everything worked after restarting Docker.

Could you give that a try? It's not clear to me what is causing this, but I had this enabled for a while without issue, so I'm thinking something changed upstream we'll need to investigate.

[johnbillion]

cc @francina who also had this problem last week

[pbearne]

Let's get this fixed I assume that we will need to support Docker Compose V2

I will create a patch to add a comment to the readme for now until we have an updated build script(s)

[ocean90]

Note that Compose V2 is still in beta and there are two related upstream reports for these issues:

• ​docker compose environment variables improperly casting while using defaults
• ​should not warn about unset variables that have inline defaults

Just a note in the readme.md to turn off composer v2
until we have a support for it in the build

Trac ticket:https://core.trac.wordpress.org/ticket/53820

[pbearne]

@ocean90 I agree we need to wait for it to be stable before we add support if needed

[desrosj]

Also related: ​https://github.com/docker/compose-cli/issues/1862.

It seems that if we change the environment section to use the list format we don't get the fatal error
We still get warnings

Trac ticket: https://core.trac.wordpress.org/ticket/53820

[pbearne]

It seems that if we change the environment section to use the list format we don't get the fatal error
We still get warnings

I have added a patch with this change

The change works with v1 as well

Let's get this into 5.8.1

Thanks for this @pbearne! Before merging, I was curious if there was any documentation indicating list format was preferred?

Looked at the compose command docs, and it ​looks like they use list formatting there. It's also the ​recommended workaround here.

Good enough for me. Going to commit.

[desrosj]

In 51673:

Build/Test Tools: Use list format when defining environment variables in Docker compose file.

This is the correct formatting detailed in the Docker compose documentation examples and helps to avoid ambiguities in the yaml parser when values that may cause warnings.

Props pbrearne, ocean90, johnbillion, desrosj.
Fixes #53820.

[desrosj]

Reopening to backport.

[desrosj]

In 51680:

Build/Test Tools: Use list format when defining environment variables in Docker compose file.

This is the correct formatting detailed in the Docker compose documentation examples and helps to avoid ambiguities in the yaml parser when values that may cause warnings.

Props pbrearne, ocean90, johnbillion, desrosj.
Merges [51673] to the 5.8 branch.
Fixes #53820.

[desrosj]

In 58599:

Build/Test Tools: Update environment variables in Docker compose file.

Follow up to [58598].

Merges [51673] to the 5.7 branch.

Props pbrearne, ocean90, johnbillion, desrosj.
See #61213, #53820.