Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#53840 closed defect (bug) (fixed)

Adding or removing items from navigation menus needs audible notification.

Reported by: joedolson's profile joedolson Owned by: joedolson's profile joedolson
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch commit
Focuses: accessibility, javascript Cc:


The customizer announces that items have been added or removed from navigation as an audible alert for screen readers after the action is performed, but the menu management at Appearance > Menus does not.

Needs wp.a11y.speak notices added to announce those confirmations.

Issue originally noted in #49876, now being broken out to isolate action on this topic.

Attachments (1)

53840.2.diff (2.4 KB) - added by joedolson 2 years ago.
Update patch to remove duplicate .speak call & change text strings

Download all attachments as: .zip

Change History (13)

#1 @joedolson
2 years ago

  • Owner set to joedolson
  • Status changed from assigned to accepted

#2 @costdev
2 years ago

Hi @joedolson, I see this is accepted - Are you working on this solo or is it alright for me to submit a PR for review?

#3 @joedolson
2 years ago

You can absolutely submit a PR, @costdev!

This ticket was mentioned in PR #1787 on WordPress/wordpress-develop by costdev.

2 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-test by costdev. View the logs.

2 years ago

This ticket was mentioned in Slack in #core-test by joedolson. View the logs.

2 years ago

This ticket was mentioned in Slack in #accessibility by ryokuhi. View the logs.

2 years ago

#8 @hellofromTonya
2 years ago

  • Keywords commit added

Hey @joedolson, the qunit tests now pass. The globals needed to be mocked for the nav tests (whereas they are available when running it live).

I'll mark it for commit as I thought you said you had already checked that it works as expected (i.e. only the tests passing remained).

Last edited 2 years ago by hellofromTonya (previous) (diff)

#9 @joedolson
2 years ago

Thanks! Yes, this worked in browser testing as expected.

#10 @joedolson
2 years ago

Minor changes/fixes:

  • Changed removal text to 'Item Removed', to match the text of the control that triggers the message.
  • Removed duplicate wp.a11y.speak call on item removal (called in eventOnClickMenuItemDelete and in removeMenuItem, but eventOnClickMenuItemDelete calls removeMenuItem, so that creates a duplicate message.)

2 years ago

Update patch to remove duplicate .speak call & change text strings

#11 @joedolson
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 52166:

Menus: Add audible notice on menu item add or remove.

Call wp.a11y.speak() to add audible notification when a menu item is added or removed from a menu.

Props joedolson, costdev, hellofromTonya.
Fixes #53840.

Note: See TracTickets for help on using tickets.