WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 4 months ago

#53847 assigned defect (bug)

Removed 'noreferrer' relationship In JS file.

Reported by: Shital Patel Owned by: Shital Patel
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing close
Focuses: javascript, administration Cc:

Description

remove "noreferrer" in js Files and add "noopener"

Attachments (1)

53847.patch (206.5 KB) - added by Shital Patel 4 months ago.
removed 'noreferrer' and added 'noopener'. let me know if any changes :)

Download all attachments as: .zip

Change History (5)

@Shital Patel
4 months ago

removed 'noreferrer' and added 'noopener'. let me know if any changes :)

#1 @Shital Patel
4 months ago

  • Owner set to Shital Patel
  • Status changed from new to assigned

#2 @Shital Patel
4 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 follow-up: @SergeyBiryukov
4 months ago

  • Keywords close added

Hi there, thanks for the patch!

Just noting that both CodeMirror and TinyMCE are external libraries, any suggested changes should be submitted upstream:

It is possible that the changes are already made upstream and will eventually be merged to WordPress as part of tickets #47218 and #48456.

Also, minified files generally should not be patched manually, they are auto-generated as part of build processes.

#4 in reply to: ↑ 3 @mukesh27
4 months ago

Yes. We don't change external libraries. Let's close this.

Replying to SergeyBiryukov:

Hi there, thanks for the patch!

Just noting that both CodeMirror and TinyMCE are external libraries, any suggested changes should be submitted upstream:

It is possible that the changes are already made upstream and will eventually be merged to WordPress as part of tickets #47218 and #48456.

Also, minified files generally should not be patched manually, they are auto-generated as part of build processes.

Note: See TracTickets for help on using tickets.