Opened 4 years ago
Closed 2 months ago
#53847 closed defect (bug) (wontfix)
Removed 'noreferrer' relationship In JS file.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | External Libraries | Keywords: | has-patch needs-testing |
| Focuses: | javascript, administration | Cc: |
Description
remove "noreferrer" in js Files and add "noopener"
Attachments (1)
Change History (6)
#3
follow-up:
↓ 4
@
4 years ago
- Keywords close added
Hi there, thanks for the patch!
Just noting that both CodeMirror and TinyMCE are external libraries, any suggested changes should be submitted upstream:
It is possible that the changes are already made upstream and will eventually be merged to WordPress as part of tickets #47218 and #48456.
Also, minified files generally should not be patched manually, they are auto-generated as part of build processes.
#4
in reply to:
↑ 3
@
4 years ago
Yes. We don't change external libraries. Let's close this.
Replying to SergeyBiryukov:
Hi there, thanks for the patch!
Just noting that both CodeMirror and TinyMCE are external libraries, any suggested changes should be submitted upstream:
It is possible that the changes are already made upstream and will eventually be merged to WordPress as part of tickets #47218 and #48456.
Also, minified files generally should not be patched manually, they are auto-generated as part of build processes.
#5
@
2 months ago
- Component changed from General to External Libraries
- Keywords close removed
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from assigned to closed
I agree with the suggestions to close. This would need to be addressed upstream before it can be merged into Core.
removed 'noreferrer' and added 'noopener'. let me know if any changes :)