WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#53851 closed defect (bug) (duplicate)

HTML entities show in dashboard 'Events and News' widget

Reported by: alanjacobmathew Owned by:
Priority: normal Milestone:
Component: Widgets Version: 4.8
Severity: normal Keywords: has-patch needs-testing
Cc: Focuses: ui, accessibility, administration

Description

HTML Code inside 'Events and News' widget in the dashboard stays as HTML itself and doesn't get converted on the frontend.
https://i.imgur.com/TGWLK7k.png

No plugins installed. Twenty Twenty Theme. v 5.8

Attachments (1)

53851.diff​ (629 bytes ) - added by sabernhardt 5 years ago.
removing HTML escape from event.title

Download all attachments as: .zip

Change History (7)

@sabernhardt
5 years ago

removing HTML escape from event.title

#1 @sabernhardt
5 years ago

  • Component General → Widgets
  • Focuses administration added
  • Keywords has-patch needs-testing added
  • Summary HTML code stays as HTML itself and not getting converted to text on dashboard page → HTML entities show in dashboard 'Events and News' widget

Thanks for the report!

Adding an extra curly brace can keep the title (and perhaps other information) un-encoded.

Version 0, edited 5 years ago by sabernhardt (next)

This ticket was mentioned in ​Slack in #accessibility by ryokuhi. ​View the logs.
5 years ago

#3 @ryokuhi
5 years ago

  • Milestone Awaiting Review → 5.9
  • Version → 4.8

The ticket was reviewed during today's Accessibility Team's bug-scrub.
The patch is very small, milestoning for 5.9.

#4 @Hareesh Pillai
5 years ago

Tested the patch, and it works as expected.

Should we also make the same change for the event city that appears in the next line?

#5 @whyisjake
5 years ago

I feel like @iandunn did some similar work around this a little while ago. I think we should keep escaping the output as we can't trust an external API (even tho WordPress controls it).

#6 @iandunn
5 years ago

  • Milestone 5.9
  • Resolution → duplicate
  • Status new → closed

Yeah, I think this is a duplicate of #41208. I agree w/ Jake about keeping the escaping, but ticket:41208#comment:2 might work.

I'll go ahead and close this, and we can continue discussion there. Feel free to re-open if I missed something and this is unique, though.

Note: See TracTickets for help on using tickets.