Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #53858, comment 12


Ignore:
Timestamp:
08/02/2021 11:49:50 AM (3 years ago)
Author:
jrf
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #53858, comment 12

    v1 v2  
    44
    55I've read through the discussion so far and would like to add some observations:
    6 1. This function ''is'' used in - at least in userland code -, though luckily not very often. Here is a [https://wpdirectory.net/search/01FC39KK20BEK3V06X1PSBDQJV WP Directory plugin search] showing this. Lots of false positives for JS code, but also some real uses and even polyfill declarations for when WP didn't have the function yet. A [https://wpdirectory.net/search/01FC3A2BFQARC0EMYY2CAYGTBF Theme Search for the same] did not yield any valid results.
     61. This function ''is'' used - at least in userland code -, though luckily not very often. Here is a [https://wpdirectory.net/search/01FC39KK20BEK3V06X1PSBDQJV WP Directory plugin search] showing this. Lots of false positives for JS code, but also some real uses and even polyfill declarations for when WP didn't have the function yet. A [https://wpdirectory.net/search/01FC3A2BFQARC0EMYY2CAYGTBF Theme Search for the same] did not yield any valid results.
    772. While this will be even more difficult to search for, the function ''may'' also be used as a callback via `add_filter()`. To be honest, I wouldn't be surprised if that type of use exists in the WP Core codebase, though I haven't done a search for it (yet). In that case, in PHP 8.1, I expect this will result in a run-time fatal error when `readonly` gets called via `apply_filters()`.
    883. A plain renaming of the function is a BC-break which is unacceptable in the WP landscape as it **will** break integrations.