WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#53870 closed enhancement (fixed)

Add missing "/" at the end of image tag in themes and wp-include files.

Reported by: Shital Patel Owned by: Shital Patel
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing
Focuses: administration, template, coding-standards Cc:

Description


Attachments (1)

53870.patch (2.3 KB) - added by akabarikalpesh 3 months ago.
I added "/". please check and let me know if any changes.

Download all attachments as: .zip

Change History (6)

#1 @Shital Patel
3 months ago

  • Owner set to Shital Patel
  • Status changed from new to accepted

wp-content/themes/twentyfourteen/inc/custom-header.php

<img src="<?php header_image(); ?>" alt="">

/wp-includes/media-template.php

<img class="crop-image" src="{{ data.url }}" alt="<?php esc_attr_e( 'Image crop area preview. Requires mouse interaction.' ); ?>">

wp-includes/SimplePie/Parser.php

<img src="'.$photo_list[$j].'">
<img src="'.$photo_list[0].'">
Last edited 3 months ago by SergeyBiryukov (previous) (diff)

@akabarikalpesh
3 months ago

I added "/". please check and let me know if any changes.

#2 @akabarikalpesh
3 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#3 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.9

Thanks for the ticket and the patch!

As previously noted in comment:2:ticket:51077, SimplePie is an external library and should not be patched here, any suggested changes to its files should be submitted upstream: https://github.com/simplepie/simplepie.

#4 @SergeyBiryukov
3 months ago

In 51541:

Bundled Themes: Add / character to <img> tags.

While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51473].

Props shital-patel, akabarikalpesh.
See #53870.

#5 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 51542:

Media: Add / character to <img> tag in wp_print_media_templates().

While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Follow-up to [47493], [48834], [50556], [51473], [51541].

Props shital-patel, akabarikalpesh.
Fixes #53870.

Note: See TracTickets for help on using tickets.