Bundled Themes: Measurement in 'px' is unnecessary

[ankitmaru]

Measurement in 'px' is unnecessary in bundled themes.

[SergeyBiryukov]

Related: #53866

[netweb]

This looks good, this change is also defined in the WordPress Coding Standards

​https://github.com/WordPress/gutenberg/blob/trunk/packages/stylelint-config/index.js#L67

Via the stylelint rule ​https://stylelint.io/user-guide/rules/list/length-zero-no-unit/

... eventually we'll get stylelint linting core, and passing 🤞🏼

[mukesh27]

Thanks for the ticket and patch.

Can you please include Twenty Twenty-One theme changes? I found a similar issue in the below some places.

​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/assets/css/style-editor.css#L227
​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/assets/sass/01-settings/global.scss#L230

[netweb]

I've removed commit from here to, running the same commands from the comments in #53866 will help cleanup the shorthand properties in themes too that touch the same lines of code:

• https://core.trac.wordpress.org/ticket/53866#comment:20
• https://core.trac.wordpress.org/ticket/53866#comment:21

[ryelle]

Both Twenty Twenty and Twenty Twenty-One have stylelint configs already, so these two rules could also be added to those config files: length-zero-no-unit, shorthand-property-no-redundant-values.

[audrasjb]

As per today's bug scrub, let's move this ticket to Future release since it’s not ready yet, we need new stylelint configs.

[sabernhardt]

If we add the stylelint configs, the admin toolbar variable will need an exception. According to ticket:52564#comment:2, the pixel unit is necessary for addition and subtraction in calc().