WordPress.org

Make WordPress Core

Opened 8 weeks ago

Closed 4 weeks ago

#53877 closed defect (bug) (fixed)

Menus: Selected display locations for new menus aren't saved

Reported by: dlh Owned by: desrosj
Milestone: 5.8.1 Priority: normal
Severity: normal Version: 5.8
Component: Menus Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

[48051] provided the ability to adjust menu settings when creating a menu on nav-menus.php. [50938] later corrected some issues with the "Display location" setting specifically. Now, however, when creating a menu, the selected menu locations aren't saved at all.

This behavior should be replicable on a fresh installation using Twenty Twenty-One by visiting Appearance > Menus, giving your first menu a name, selecting a location or two, and saving. The menu will save, but the locations won't.

The linked PR attempts to address the issue by assigning only the locations in $_POST['menu-locations'] to the new menu.

Change History (10)

#2 @dlh
8 weeks ago

  • Version changed from 5.7 to 5.8

#3 @andraganescu
8 weeks ago

  • Milestone changed from Awaiting Review to 5.8.1

I can confirm this bug via testing.

#4 @mukesh27
7 weeks ago

Thanks for the ticket and patch.

PR working fine for me.

#5 @mukesh27
5 weeks ago

#54002 was marked as a duplicate.

#6 @desrosj
5 weeks ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to reviewing

#7 @peterwilsoncc
4 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 51688:

Menus: Save display locations for new menus.

Fixes a bug preventing the locations saving when creating a new menu. Introduced in [50938].

Props dlh, andraganescu, mukesh27, desrosj.
Fixes #53877.

#9 @peterwilsoncc
4 weeks ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for merging in to 5.8 branch.

#10 @desrosj
4 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 51690:

Menus: Save display locations for new menus.

Fixes a bug preventing the locations saving when creating a new menu. Introduced in [50938].

Props dlh, andraganescu, mukesh27, desrosj, peterwilsoncc.
Merges [51688] to the 5.8 branch.
Fixes #53877.

Note: See TracTickets for help on using tickets.