WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#53882 closed defect (bug) (fixed)

phpunit test for wp_nonce_ays

Reported by: pbearne's profile pbearne Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch dev-feedback has-unit-tests
Focuses: Cc:

Description

tests for wp_nonce_ays

AND UPDATE CODE for wp_die_handler to pass the response into WPDieException so that expectExceptionCode() call work

Change History (9)

This ticket was mentioned in ​PR #1549 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #1

  • Keywords has-unit-tests added

tests for wp_nonce_ays
AND UPDATE CODE for wp_die_handler to pass the response into WPDieException so that expectExceptionCode() call work

Trac ticket: https://core.trac.wordpress.org/ticket/53882

This ticket was mentioned in ​Slack in #core-test by pbearne. ​View the logs.
3 years ago

#3 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 5.9

#4 @mukesh27
3 years ago

  • Keywords needs-refresh added

Hi there!

[PR 1549 ​https://github.com/WordPress/wordpress-develop/pull/1549] fails for PHP coding standards. Can you please correct it?

#5 @pbearne
3 years ago

Fixed the PR

#6 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51608:

Tests: Add unit tests for the wp_nonce_ays() function.

Update the wp_die_handler() method to pass the response into WPDieException so that expectExceptionCode() calls work as expected.

Follow-up to [1221/tests], [3934], [4009], [12309].

Props pbearne, jrf, mukesh27.
Fixes #53882.

This ticket was mentioned in ​PR #1603 on ​WordPress/wordpress-develop by ​pbearne.
3 years ago #8

  • Keywords needs-refresh removed

just couple of tests for wp_nonce_ays()

Trac ticket: https://core.trac.wordpress.org/ticket/53882

Note: See TracTickets for help on using tickets.