Make WordPress Core

#53892 closed defect (bug) (fixed)

Twenty Twenty-One: Dark Mode toggle also appears in bottom left corner

Reported by: musabshakeel's profile musabshakeel Owned by: desrosj's profile desrosj
Milestone: 5.9 Priority: normal
Severity: minor Version: 5.6
Component: Bundled Theme Keywords: has-screenshots has-patch commit
Focuses: ui, ui-copy Cc:

Description

  1. Open Browser
  2. Install WordPress and use TwentyTwentyOne theme
  3. Visit Customize > Colors & Dark Mode

https://i.ibb.co/m9dtkkn/Screenshot-2.png

Attachments (2)

53892.diff (1.0 KB) - added by dilipbheda 22 months ago.
Changed the wrong word in color & dark mode custom component
53892.2.diff (1021 bytes) - added by dilipbheda 22 months ago.
Updated patch

Download all attachments as: .zip

Change History (8)

@dilipbheda
22 months ago

Changed the wrong word in color & dark mode custom component

#1 @dilipbheda
22 months ago

  • Component changed from General to Themes
  • Keywords has-patch added; needs-patch removed

#2 @sabernhardt
22 months ago

  • Component changed from Themes to Bundled Theme
  • Focuses ui-copy added
  • Summary changed from Dark Mode bottom left to Twenty Twenty-One: Dark Mode toggle also appears in bottom left corner
  • Version changed from 5.8 to 5.6

The toggle button can appear in either the bottom-right or bottom-left, depending on language direction.
https://wordpress.org/support/article/twenty-twenty-one/#dark-mode-support

The theme setting could clarify the two corner positions, as in the support article, or else the setting text could change to "bottom corner" for simplicity.

@dilipbheda
22 months ago

Updated patch

#3 @SergeyBiryukov
22 months ago

  • Milestone changed from Awaiting Review to 5.9

#4 @sabernhardt
19 months ago

  • Keywords commit added

The patch still applies; marking for commit consideration.

#5 @desrosj
19 months ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#6 @desrosj
19 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 52211:

Twenty Twenty-One: Correct description of Dark Mode in the Customizer.

The Dark Mode toggle can appear in both bottom corners. This removes “right” from the description to be accurate for both RTL and LTR languages.

Props musabshakeel, dilipbheda, sabernhardt.
Fixes #53892.

Note: See TracTickets for help on using tickets.